Comment on GRPC latency measure reuse (#1217)

smhendrickson · web-flow · commit 8e242ede942b · 2020-07-06T09:41:59.000+10:00
diff --git a/plugin/ocgrpc/client_metrics.go b/plugin/ocgrpc/client_metrics.go
@@ -60,6 +60,8 @@ var (
 		Aggregation: DefaultMillisecondsDistribution,
 	}
 
+	// Purposely reuses the count from `ClientRoundtripLatency`, tagging
+	// with method and status to result in ClientCompletedRpcs.
 	ClientCompletedRPCsView = &view.View{
 		Measure:     ClientRoundtripLatency,
 		Name:        "grpc.io/client/completed_rpcs",
diff --git a/plugin/ocgrpc/server_metrics.go b/plugin/ocgrpc/server_metrics.go
@@ -63,6 +63,8 @@ var (
 		Aggregation: DefaultMillisecondsDistribution,
 	}
 
+	// Purposely reuses the count from `ServerLatency`, tagging
+	// with method and status to result in ServerCompletedRpcs.
 	ServerCompletedRPCsView = &view.View{
 		Name:        "grpc.io/server/completed_rpcs",
 		Description: "Count of RPCs by method and status.",

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,8 @@ var (`
`60`	`60`	`Aggregation: DefaultMillisecondsDistribution,`
`61`	`61`	`}`
`62`	`62`
	`63`	+ // Purposely reuses the count from `ClientRoundtripLatency`, tagging
	`64`	`+ // with method and status to result in ClientCompletedRpcs.`
`63`	`65`	`ClientCompletedRPCsView = &view.View{`
`64`	`66`	`Measure: ClientRoundtripLatency,`
`65`	`67`	`Name: "grpc.io/client/completed_rpcs",`
Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,8 @@ var (`
`63`	`63`	`Aggregation: DefaultMillisecondsDistribution,`
`64`	`64`	`}`
`65`	`65`
	`66`	+ // Purposely reuses the count from `ServerLatency`, tagging
	`67`	`+ // with method and status to result in ServerCompletedRpcs.`
`66`	`68`	`ServerCompletedRPCsView = &view.View{`
`67`	`69`	`Name: "grpc.io/server/completed_rpcs",`
`68`	`70`	`Description: "Count of RPCs by method and status.",`