More clean up (#38)

* added samples

* fix urls

* link to sample

* few more warnings

* addressed PR feedback

* speed up build

Author: SergeyKanzhelev

CHANGELOG.md

@@ -1,5 +1,6 @@
 # Unreleased
 
+- Initial version of Application Insights exporter implemented.
 - Zipkin exporter implemented.
 - Initial version of SDK published. It is based on contribution from Pivotal
   [from](https://github.com/SteeltoeOSS/Management/tree/dev/src/Steeltoe.Management.OpenCensus).

OpenCensus.sln

@@ -36,6 +36,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".vsts", ".vsts", "{61188153
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenCensus.Exporter.ApplicationInsights", "src\OpenCensus.Exporter.ApplicationInsights\OpenCensus.Exporter.ApplicationInsights.csproj", "{4493F5D9-874E-4FBF-B2F3-37890BD910E0}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Samples", "src\Samples\Samples.csproj", "{C58393EB-32E2-4AC6-9170-697B36306E15}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -58,6 +60,10 @@ Global
 		{4493F5D9-874E-4FBF-B2F3-37890BD910E0}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{4493F5D9-874E-4FBF-B2F3-37890BD910E0}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{4493F5D9-874E-4FBF-B2F3-37890BD910E0}.Release|Any CPU.Build.0 = Release|Any CPU
+		{C58393EB-32E2-4AC6-9170-697B36306E15}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{C58393EB-32E2-4AC6-9170-697B36306E15}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{C58393EB-32E2-4AC6-9170-697B36306E15}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{C58393EB-32E2-4AC6-9170-697B36306E15}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

README.md

@@ -1,8 +1,12 @@
 # OpenCensus .NET SDK - distributed tracing and stats collection framework
 
 [![Gitter chat][gitter-image]][gitter-url]
+[![Build Status](https://opencensus.visualstudio.com/continuous-integration/_apis/build/status/ci-myget-update.yml)](https://opencensus.visualstudio.com/continuous-integration/_build/latest?definitionId=3)
+
+| Source | OpenCensus                                                       | Zipkin Exporter                                                                                  | Application Insights exporter                                                            |
+|--------|------------------------------------------------------------------|--------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------|
+| MyGet  | [![MyGet Nightly][opencensus-myget-image]][opencensus-myget-url] | [![MyGet Nightly][opencensus-exporter-zipkin-myget-image]][opencensus-exporter-zipkin-myget-url] | [![MyGet Nightly][opencensus-exporter-ai-myget-image]][opencensus-exporter-ai-myget-url] |
 
-MyGet: [![MyGet Nightly][opencensus-myget-image]][opencensus-myget-url]
 
 OpenCensus is a toolkit for collecting application performance and behavior
 data. It currently includes 3 APIs: stats, tracing and tags.
@@ -14,37 +18,56 @@ major release.
 Please join [gitter](https://gitter.im/census-instrumentation/Lobby) for help
 or feedback on this project.
 
-We encourage contributions. Use tags
-[up-for-grabs](https://github.com/census-instrumentation/opencensus-csharp/issues?q=is%3Aissue+is%3Aopen+label%3Aup-for-grabs)
-and [good first
-issue](https://github.com/census-instrumentation/opencensus-csharp/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
-to get started with the project. Follow [CONTRIBUTING](CONTRIBUTING.md) guide
-to report issues or submit a proposal.
+We encourage contributions. Use tags [up-for-grabs][up-for-grabs-issues] and
+[good first issue][good-first-issues] to get started with the project. Follow
+[CONTRIBUTING](CONTRIBUTING.md) guide to report issues or submit a proposal.
 
 ## OpenCensus Quickstart
 
 ### Using Zipkin exporter
 
 Configure Zipkin exporter to see traces in Zipkin UI.
 
-1. Get Zipkin using getting [started
-   guide](https://zipkin.io/pages/quickstart.html).
+1. Get Zipkin using [getting started guide][zipkin-get-started].
 2. Start `ZipkinTraceExporter` as below:
+3. See [sample][zipkin-sample] for example use.
 
 ``` csharp
 var exporter = new ZipkinTraceExporter(
   new ZipkinTraceExporterOptions() {
-    Endpoint = "https://<zipkin-server:9411>/api/v2/spans",
+    Endpoint = new Uri("https://<zipkin-server:9411>/api/v2/spans"),
     ServiceName = typeof(Program).Assembly.GetName().Name,
   },
   Tracing.ExportComponent);
 exporter.Start();
 
-var span = tracer.SpanBuilder("incoming request").SetSampler(Samplers.AlwaysSample).StartSpan();
+var span = tracer
+            .SpanBuilder("incoming request")
+            .SetSampler(Samplers.AlwaysSample)
+            .StartSpan();
+
 Thread.Sleep(TimeSpan.FromSeconds(1));
 span.End();
 ```
 
+### Using Application Insights exporter
+
+1. Create [Application Insights][ai-get-started] resource.
+2. Set instrumentation key via telemetry configuration object
+   (`new TelemetryConfiguration("iKey")`). This object may be injected via
+   dependency injection as well.
+3. Instantiate a new instance of `ApplicationInsightsExporter`.
+4. See [sample][ai-sample] for example use.
+
+``` csharp
+var config = new TelemetryConfiguration("iKey")
+var exporter = new ApplicationInsightsExporter(
+    Tracing.ExportComponent,
+    Stats.ViewManager,
+    config); // either global or local config can be used
+exporter.Start();
+```
+
 ## Versioning
 
 This library follows [Semantic Versioning][semver].
@@ -64,10 +87,17 @@ opencensus libraries, then there is no deprecation period. Otherwise, we will
 deprecate it for 18 months before removing it, if possible.
 
 [gitter-image]: https://badges.gitter.im/census-instrumentation/lobby.svg
-[gitter-url]:
-https://gitter.im/census-instrumentation/lobby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge
-[opencensus-myget-image]:
-https://img.shields.io/myget/opencensus/vpre/OpenCensus.svg
-[opencensus-myget-url]:
-https://www.myget.org/feed/opencensus/package/nuget/OpenCensus [semver]:
-http://semver.org/
+[gitter-url]:https://gitter.im/census-instrumentation/lobby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge
+[opencensus-myget-image]:https://img.shields.io/myget/opencensus/vpre/OpenCensus.svg
+[opencensus-myget-url]: https://www.myget.org/feed/opencensus/package/nuget/OpenCensus
+[opencensus-exporter-zipkin-myget-image]:https://img.shields.io/myget/opencensus/vpre/OpenCensus.Exporter.Zipkin.svg
+[opencensus-exporter-zipkin-myget-url]: https://www.myget.org/feed/opencensus/package/nuget/OpenCensus.Exporter.Zipkin
+[opencensus-exporter-ai-myget-image]:https://img.shields.io/myget/opencensus/vpre/OpenCensus.Exporter.ApplicationInsights.svg
+[opencensus-exporter-ai-myget-url]: https://www.myget.org/feed/opencensus/package/nuget/OpenCensus.Exporter.ApplicationInsights
+[up-for-grabs-issues]: https://github.com/census-instrumentation/opencensus-csharp/issues?q=is%3Aissue+is%3Aopen+label%3Aup-for-grabs
+[good-first-issues]: https://github.com/census-instrumentation/opencensus-csharp/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22
+[zipkin-get-started]: https://zipkin.io/pages/quickstart.html
+[ai-get-started]: https://docs.microsoft.com/azure/application-insights
+[semver]: http://semver.org/
+[ai-sample]: https://github.com/census-instrumentation/opencensus-csharp/blob/develop/src/Samples/TestApplicationInsights.cs
+[zipkin-sample]: https://github.com/census-instrumentation/opencensus-csharp/blob/develop/src/Samples/TestZipkin.cs

src/OpenCensus.Exporter.ApplicationInsights/ApplicationInsightsExporter.cs

@@ -48,10 +48,10 @@ public class ApplicationInsightsExporter
         /// <summary>
         /// Instantiates a new instance of an exporter from Open Census to Azure Application Insights.
         /// </summary>
-        /// <param name="telemetryConfiguration">Telemetry configuration to use to report telemetry.</param>
         /// <param name="exportComponent">Exporter to get traces and metrics from.</param>
         /// <param name="viewManager">View manager to get stats from.</param>
-        public ApplicationInsightsExporter(TelemetryConfiguration telemetryConfiguration, IExportComponent exportComponent, IViewManager viewManager)
+        /// <param name="telemetryConfiguration">Telemetry configuration to use to report telemetry.</param>
+        public ApplicationInsightsExporter(IExportComponent exportComponent, IViewManager viewManager, TelemetryConfiguration telemetryConfiguration)
         {
             this.exportComponent = exportComponent;
             this.viewManager = viewManager;

src/OpenCensus.Exporter.ApplicationInsights/Implementation/MetricsExporterThread.cs

@@ -87,7 +87,7 @@ internal void Export()
                 {
                     var metricTelemetry = new MetricTelemetry
                     {
-                        Name = data.View.Name.AsString
+                        Name = data.View.Name.AsString,
                     };
 
                     for (int i = 0; i < value.Key.Values.Count; i++)
@@ -115,6 +115,7 @@ internal void Export()
                             {
                                 metricTelemetry.Sum = sum.Sum;
                             }
+
                             return null;
                         },
                         (combined) =>
@@ -123,6 +124,7 @@ internal void Export()
                             {
                                 metricTelemetry.Sum = sum.Sum;
                             }
+
                             return null;
                         },
                         (combined) =>
@@ -131,13 +133,15 @@ internal void Export()
                             {
                                 metricTelemetry.Sum = count.Count;
                             }
+
                             return null;
                         },
                         (combined) =>
                         {
                             if (combined is IMeanData mean)
                             {
                             }
+
                             return null;
                         },
                         (combined) =>
@@ -158,6 +162,7 @@ internal void Export()
                             {
                                 metricTelemetry.Sum = lastValue.LastValue;
                             }
+
                             return null;
                         },
                         (combined) =>
@@ -166,6 +171,7 @@ internal void Export()
                             {
                                 metricTelemetry.Sum = lastValue.LastValue;
                             }
+
                             return null;
                         },
                         (combined) =>
@@ -174,6 +180,7 @@ internal void Export()
                             {
                                 // TODO: report an error
                             }
+
                             return null;
                         });
                     this.telemetryClient.TrackMetric(metricTelemetry);

src/OpenCensus.Exporter.ApplicationInsights/OpenCensus.Exporter.ApplicationInsights.csproj

@@ -1,33 +1,31 @@
 <Project Sdk="Microsoft.NET.Sdk">
+  <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildProjectDirectory), 'OpenCensus.sln'))\build\Common.prod.props" />
 
   <PropertyGroup>
     <TargetFrameworks>net46;netstandard2.0</TargetFrameworks>
     <TargetFrameworks Condition="$(OS) != 'Windows_NT'">netstandard2.0</TargetFrameworks>
+    <IncludeSymbols>True</IncludeSymbols>
   </PropertyGroup>
 
   <PropertyGroup>
-    <CodeAnalysisRuleSet>$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildProjectDirectory), 'OpenCensus.sln'))\build\OpenCensus.prod.ruleset</CodeAnalysisRuleSet>
-  </PropertyGroup>
-
-  <PropertyGroup>
-    <DocumentationFile Condition="$(OS) == 'Windows_NT'">$(OutputPath)/$(TargetFramework)/$(AssemblyName).xml</DocumentationFile>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net46|AnyCPU'">
-    <PlatformTarget>x64</PlatformTarget>
+    <Description>Application Insights exporter for Open Census.</Description>
+    <PackageTags>Tracing;OpenCensus;Management;Monitoring;application-insights;azure;distributed-tracing</PackageTags>
+    <PackageIconUrl>https://opencensus.io/images/opencensus-logo.png</PackageIconUrl>
+    <PackageProjectUrl>https://opencensus.io</PackageProjectUrl>
+    <PackageLicenseUrl>https://www.apache.org/licenses/LICENSE-2.0</PackageLicenseUrl>
+    <Authors>OpenCensus authors</Authors>
+    <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
   </PropertyGroup>
 
   <ItemGroup>
     <AdditionalFiles Include="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildProjectDirectory), 'OpenCensus.sln'))\build\stylecop.json" />
   </ItemGroup>
 
-
   <ItemGroup>
     <ProjectReference Include="..\OpenCensus\OpenCensus.csproj" />
-    <PackageReference Include="StyleCop.Analyzers" Version="1.0.2">
+    <PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta008">
       <PrivateAssets>All</PrivateAssets>
     </PackageReference>
     <PackageReference Include="Microsoft.ApplicationInsights" Version="2.8.0-beta1" />
   </ItemGroup>
-
 </Project>

src/OpenCensus.Exporter.Zipkin/Implementation/TraceExporterHandler.cs

@@ -216,7 +216,7 @@ private async void SendSpansAsync(List<ZipkinSpan> spans)
         {
             try
             {
-                var requestUri = new Uri(this.options.Endpoint);
+                var requestUri = this.options.Endpoint;
                 var request = this.GetHttpRequestMessage(HttpMethod.Post, requestUri);
                 request.Content = this.GetRequestContent(spans);
                 await this.DoPost(this.httpClient, request);

src/OpenCensus.Exporter.Zipkin/OpenCensus.Exporter.Zipkin.csproj

@@ -2,16 +2,14 @@
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildProjectDirectory), 'OpenCensus.sln'))\build\Common.prod.props" />
 
   <PropertyGroup>
-    <Description>OpenCensus .NET API</Description>
     <TargetFrameworks>net46;netstandard2.0</TargetFrameworks>
     <TargetFrameworks Condition="$(OS) != 'Windows_NT'">netstandard2.0</TargetFrameworks>
-    <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
-    <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
-    <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
-    <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <IncludeSymbols>True</IncludeSymbols>
-    <PackageId>OpenCensus.Export.Zipkin</PackageId>
-    <PackageTags>Tracing;OpenCensus;Management;Monitoring;Zipkin</PackageTags>
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <Description>Zipkin exporter for OpenCensus</Description>
+    <PackageTags>Tracing;OpenCensus;Management;Monitoring;Zipkin;distributed-tracing</PackageTags>
     <PackageIconUrl>https://opencensus.io/images/opencensus-logo.png</PackageIconUrl>
     <PackageProjectUrl>https://opencensus.io</PackageProjectUrl>
     <PackageLicenseUrl>https://www.apache.org/licenses/LICENSE-2.0</PackageLicenseUrl>
@@ -27,9 +25,7 @@
     <PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
   </ItemGroup>
 
-
   <ItemGroup Condition="'$(TargetFramework)' == 'net46'">
     <Reference Include="System.Net.Http" />
   </ItemGroup>
-
 </Project>

src/OpenCensus.Exporter.Zipkin/ZipkinTraceExporterOptions.cs

@@ -27,7 +27,7 @@ public sealed class ZipkinTraceExporterOptions
         /// Gets or sets Zipkin endpoint address. See https://zipkin.io/zipkin-api/#/default/post_spans. 
         /// Typically https://zipkin-server-name:9411/api/v2/spans.
         /// </summary>
-        public string Endpoint { get; set; } = "http://localhost:9411/api/v2/spans";
+        public Uri Endpoint { get; set; } = new Uri("http://localhost:9411/api/v2/spans");
 
         /// <summary>
         /// Gets or sets timeout in seconds.

src/OpenCensus/Api/Stats/IAggregation.cs

@@ -21,12 +21,12 @@ namespace OpenCensus.Stats
 
     public interface IAggregation
     {
-        M Match<M>(
-             Func<ISum, M> p0,
-             Func<ICount, M> p1,
-             Func<IMean, M> p2,
-             Func<IDistribution, M> p3,
-             Func<ILastValue, M> p4,
-             Func<IAggregation, M> p6);
+        T Match<T>(
+             Func<ISum, T> p0,
+             Func<ICount, T> p1,
+             Func<IMean, T> p2,
+             Func<IDistribution, T> p3,
+             Func<ILastValue, T> p4,
+             Func<IAggregation, T> p6);
     }
 }