|
| 1 | +# rbs_inline: enabled |
| 2 | + |
| 3 | +require "database_test_helper" |
| 4 | +require "portable_telemetry_assertions" |
| 5 | + |
| 6 | +class ActivationRecoveryBackoffTest < ActiveSupport::TestCase |
| 7 | + include PortableTelemetryAssertions |
| 8 | + |
| 9 | + class Counter < SolidObjects::Actor |
| 10 | + actor_type "activation-recovery-backoff" |
| 11 | + attribute :count, default: 0 |
| 12 | + |
| 13 | + class << self |
| 14 | + attr_accessor :before_commit |
| 15 | + end |
| 16 | + |
| 17 | + def increment(label:) |
| 18 | + self.count += 1 |
| 19 | + emit(:applied, label:) |
| 20 | + self.class.before_commit&.call(label) |
| 21 | + count |
| 22 | + end |
| 23 | + end |
| 24 | + |
| 25 | + setup do |
| 26 | + SolidObjects.configuration.lease_duration = 0.2 |
| 27 | + SolidObjects.configuration.lease_renewal_interval = 0.05 |
| 28 | + SolidObjects.configuration.max_attempts = 1 |
| 29 | + @clock = { now: SolidObjects.database_adapter.database_now } |
| 30 | + clock = @clock |
| 31 | + SolidObjects.database_adapter.define_singleton_method(:database_now) { clock.fetch(:now) } |
| 32 | + Counter.before_commit = ->(label) { clock[:now] += 0.201 if label == "slow" } |
| 33 | + @events = [] |
| 34 | + SolidObjects.configuration.instrumentation = ->(event) { @events << event } |
| 35 | + @workers = [] |
| 36 | + end |
| 37 | + |
| 38 | + teardown do |
| 39 | + @workers.each(&:stop) |
| 40 | + SolidObjects.database_adapter.singleton_class.remove_method(:database_now) |
| 41 | + Counter.before_commit = nil |
| 42 | + end |
| 43 | + |
| 44 | + test "recovers once immediately then delays without blocking other actors or reordering" do |
| 45 | + worker = new_worker |
| 46 | + first = Counter.ref("one").async.increment(label: "slow") |
| 47 | + later = Counter.ref("one").async.increment(label: "later") |
| 48 | + assert_equal 0, worker.run_once |
| 49 | + assert_equal 0, worker.run_once |
| 50 | + assert_equal 2, stored_message(first).attempt_count |
| 51 | + assert_equal 0, worker.run_once |
| 52 | + assert_in_delta 1, remaining_delay(first) |
| 53 | + other = Counter.ref("other").async.increment(label: "other") |
| 54 | + assert_equal 1, worker.run_once |
| 55 | + assert_equal 1, stored_message(other).result |
| 56 | + assert_equal 0, stored_message(later).attempt_count |
| 57 | + assert_empty stored_message(first).instance.state |
| 58 | + |
| 59 | + @clock[:now] += 0.999 |
| 60 | + assert_equal 0, worker.run_once |
| 61 | + @clock[:now] += 0.001 |
| 62 | + assert_equal 0, worker.run_once |
| 63 | + assert_equal 3, stored_message(first).attempt_count |
| 64 | + assert_equal 0, worker.run_once |
| 65 | + assert_in_delta 2, remaining_delay(first) |
| 66 | + assert_empty SolidObjects::DeadLetter.all |
| 67 | + |
| 68 | + Counter.before_commit = nil |
| 69 | + @clock[:now] += 2 |
| 70 | + assert_equal 2, worker.run_once |
| 71 | + assert_equal 1, stored_message(first).result |
| 72 | + assert_equal 2, stored_message(later).result |
| 73 | + assert_equal %w[later other slow], SolidObjects::Effect.all.map { |effect| effect.arguments.fetch("label") }.sort |
| 74 | + end |
| 75 | + |
| 76 | + %w[stop cleanup replacement].each do |recovery| |
| 77 | + test "preserves custom recovery waits through #{recovery}" do |
| 78 | + delay_arguments = [] |
| 79 | + SolidObjects.configuration.retry_delay = ->(attempt) { |
| 80 | + delay_arguments << attempt |
| 81 | + attempt * 0.025 |
| 82 | + } |
| 83 | + worker = new_worker |
| 84 | + reference = Counter.ref("one").async.increment(label: "slow") |
| 85 | + 2.times { worker.run_once } |
| 86 | + worker.stop if recovery == "stop" |
| 87 | + if recovery == "cleanup" |
| 88 | + @clock[:now] += SolidObjects.configuration.process_alive_threshold + 1 |
| 89 | + SolidObjects::ProcessRegistry.cleanup_dead |
| 90 | + end |
| 91 | + replacement = new_worker |
| 92 | + assert_equal 0, replacement.run_once |
| 93 | + assert_equal [ 1 ], delay_arguments |
| 94 | + assert_in_delta 0.025, remaining_delay(reference) |
| 95 | + worker.stop |
| 96 | + assert_in_delta 0.025, remaining_delay(reference) |
| 97 | + |
| 98 | + @clock[:now] += 0.025 |
| 99 | + replacement.run_once |
| 100 | + assert_equal 3, stored_message(reference).attempt_count |
| 101 | + assert_equal 0, replacement.run_once |
| 102 | + assert_equal [ 1, 2 ], delay_arguments |
| 103 | + assert_in_delta 0.05, remaining_delay(reference) |
| 104 | + end |
| 105 | + end |
| 106 | + |
| 107 | + test "caps default recovery waits without dead lettering lease loss" do |
| 108 | + worker = new_worker |
| 109 | + reference = Counter.ref("one").async.increment(label: "slow") |
| 110 | + 2.times { worker.run_once } |
| 111 | + [ 1, 2, 4, 8, 16, 32, 60, 60 ].each do |delay| |
| 112 | + worker.run_once |
| 113 | + assert_in_delta delay, remaining_delay(reference) |
| 114 | + assert_empty SolidObjects::DeadLetter.all |
| 115 | + @clock[:now] += delay |
| 116 | + worker.run_once |
| 117 | + end |
| 118 | + end |
| 119 | + |
| 120 | + test "emits each lost message attempt and stops from its instrumentation callback" do |
| 121 | + worker = new_worker |
| 122 | + reference = Counter.ref("one").async.increment(label: "slow") |
| 123 | + observed = [] |
| 124 | + SolidObjects.configuration.retry_delay = ->(_) { 0 } |
| 125 | + SolidObjects.configuration.instrumentation = ->(event) do |
| 126 | + next unless event.fetch("name") == "solid_objects.activation.lost" |
| 127 | + |
| 128 | + observed << event |
| 129 | + worker.request_shutdown if observed.length == 3 |
| 130 | + end |
| 131 | + forced_shutdown = false |
| 132 | + guard = Thread.new do |
| 133 | + sleep 2 |
| 134 | + forced_shutdown = true |
| 135 | + worker.request_shutdown |
| 136 | + end |
| 137 | + begin |
| 138 | + worker.run |
| 139 | + ensure |
| 140 | + guard.kill |
| 141 | + guard.join |
| 142 | + end |
| 143 | + assert_not forced_shutdown |
| 144 | + assert_predicate worker, :stopped? |
| 145 | + assert_equal [ 1, 2, 3 ], observed.map { |event| event.fetch("attempt") } |
| 146 | + assert observed.all? { |event| event.fetch("messageId") == reference.id.to_s } |
| 147 | + observed.each { |event| assert_portable_attributes(event) } |
| 148 | + assert worker.shutdown_requested? |
| 149 | + assert_empty stored_message(reference).instance.state |
| 150 | + assert_empty SolidObjects::DeadLetter.all |
| 151 | + end |
| 152 | + |
| 153 | + test "keeps a handler failure terminal with one allowed attempt" do |
| 154 | + Counter.before_commit = ->(_) { raise "handler failure" } |
| 155 | + worker = new_worker |
| 156 | + reference = Counter.ref("one").async.increment(label: "fail") |
| 157 | + worker.run_once |
| 158 | + assert_predicate stored_message(reference), :dead? |
| 159 | + assert_equal 1, stored_message(reference).attempt_count |
| 160 | + end |
| 161 | + |
| 162 | + test "uses total claims for recovery after an earlier handler failure" do |
| 163 | + delay_arguments = [] |
| 164 | + SolidObjects.configuration.max_attempts = 3 |
| 165 | + SolidObjects.configuration.retry_delay = ->(attempt) { |
| 166 | + delay_arguments << attempt |
| 167 | + attempt * 0.025 |
| 168 | + } |
| 169 | + worker = new_worker |
| 170 | + reference = Counter.ref("mixed").async.increment(label: "slow") |
| 171 | + Counter.before_commit = ->(_) { raise "handler failure" } |
| 172 | + worker.run_once |
| 173 | + assert_equal [ 1 ], delay_arguments |
| 174 | + @clock[:now] += 0.025 |
| 175 | + Counter.before_commit = ->(_) { @clock[:now] += 0.201 } |
| 176 | + worker.run_once |
| 177 | + assert_equal 0, worker.run_once |
| 178 | + assert_equal [ 1, 1 ], delay_arguments |
| 179 | + assert_in_delta 0.025, remaining_delay(reference) |
| 180 | + assert_equal 2, stored_message(reference).attempt_count |
| 181 | + @clock[:now] += 0.025 |
| 182 | + Counter.before_commit = ->(_) { raise "handler failed again" } |
| 183 | + worker.run_once |
| 184 | + assert_predicate stored_message(reference), :dead? |
| 185 | + assert_equal 3, stored_message(reference).attempt_count |
| 186 | + end |
| 187 | + |
| 188 | + private |
| 189 | + |
| 190 | + def new_worker |
| 191 | + SolidObjects::Worker.new.tap { |worker| @workers << worker } |
| 192 | + end |
| 193 | + |
| 194 | + def stored_message(reference) |
| 195 | + SolidObjects::Message.find(reference.id) |
| 196 | + end |
| 197 | + |
| 198 | + def remaining_delay(reference) |
| 199 | + ready = SolidObjects::ReadyMessage.find_by(message_id: reference.id) |
| 200 | + assert ready, "expected recovered claim to wait in ready membership" |
| 201 | + ready.available_at - @clock.fetch(:now) |
| 202 | + end |
| 203 | +end |
0 commit comments