Skip to content

Commit 1f25c0d

Browse files
test(jco): re-enable all stream tests
1 parent 13de370 commit 1f25c0d

1 file changed

Lines changed: 12 additions & 17 deletions

File tree

packages/jco/test/p3/stream.js

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,10 @@ suite("stream<T> lifts", () => {
6666
let vals = [0, 100, 65535];
6767
let stream = await instance["jco:test-components/get-stream-async"].getStreamU16(vals);
6868
await checkStreamValues({ stream, vals, typeName: "u16" });
69-
// TODO(fix): under/overflowing values hang
7069

7170
vals = [-32_768, 0, 32_767];
7271
stream = await instance["jco:test-components/get-stream-async"].getStreamS16(vals);
7372
await checkStreamValues({ stream, vals, typeName: "u16" });
74-
// TODO(fix): under/overflowing values hang
7573
});
7674

7775
test.concurrent("u64/s64", async () => {
@@ -81,30 +79,27 @@ suite("stream<T> lifts", () => {
8179
let vals = [0n, 100n, 65535n];
8280
let stream = await instance["jco:test-components/get-stream-async"].getStreamU64(vals);
8381
await checkStreamValues({ stream, vals, typeName: "u64" });
84-
// TODO(fix): under/overflowing values hang
8582

8683
vals = [-32_768n, 0n, 32_767n];
8784
stream = await instance["jco:test-components/get-stream-async"].getStreamS64(vals);
8885
await checkStreamValues({ stream, vals, typeName: "s64" });
89-
// TODO(fix): under/overflowing values hang
9086
});
9187

92-
// // TODO(fix): stream gets stuck waiting, u8/s8 require special case
93-
test.skip("u8/s8", async () => {
88+
test.concurrent("u8/s8", async () => {
9489
assert.instanceOf(instance["jco:test-components/get-stream-async"].getStreamU8, AsyncFunction);
9590
assert.instanceOf(instance["jco:test-components/get-stream-async"].getStreamS8, AsyncFunction);
9691

97-
// let vals = [0, 1, 255];
98-
// let stream = await instance["jco:test-components/get-stream-async"].getStreamU8(vals);
99-
// await checkStreamValues({ stream, vals, typeName: "u8" });
100-
//
101-
// vals = [-11, -22, -33, -128, 127, 128];
102-
// stream = await instance["jco:test-components/get-stream-async"].getStreamS8(vals);
103-
// assert.equal(vals[0], await stream.next());
104-
// assert.equal(vals[1], await stream.next());
105-
// assert.equal(vals[2], await stream.next());
106-
// assert.equal(vals[3], await stream.next());
107-
// assert.equal(vals[4], await stream.next());
92+
let vals = [0, 1, 255];
93+
let stream = await instance["jco:test-components/get-stream-async"].getStreamU8(vals);
94+
await checkStreamValues({ stream, vals, typeName: "u8" });
95+
96+
vals = [-11, -22, -33, -128, 127, 128];
97+
stream = await instance["jco:test-components/get-stream-async"].getStreamS8(vals);
98+
assert.equal(vals[0], await stream.next());
99+
assert.equal(vals[1], await stream.next());
100+
assert.equal(vals[2], await stream.next());
101+
assert.equal(vals[3], await stream.next());
102+
assert.equal(vals[4], await stream.next());
108103
});
109104

110105
test.concurrent("f32/f64", async () => {

0 commit comments

Comments
 (0)