From 14e6cbe0bdd96ace54dd0b46d21ef01bc5db2755 Mon Sep 17 00:00:00 2001 From: kkdao <44775666+kkdao@users.noreply.github.com> Date: Wed, 26 Aug 2026 13:16:10 -0400 Subject: [PATCH] ci(mutants): build the baseline with --all-features The incremental mutants lane has been failing at the unmutated baseline, so no mutants are ever tested. Args after `--` are handed to the test phase only, so the baseline build ran with default features. `bdk_sp` gates serde behind an optional feature while its tests derive Deserialize, which leaves the test targets uncompilable without it and fails the build before mutation starts. Pass the feature through `--cargo-arg` instead, which applies to every cargo invocation including the build. It also has to come out of the trailing args: `--cargo-arg` already adds it to the test command, and cargo rejects `--all-features` given twice. Verified against the diff from #70, which previously died at the baseline: 7 mutants found, 6 caught, 1 unviable, none missed. --- .github/workflows/mutations.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mutations.yml b/.github/workflows/mutations.yml index 3cf8e21..c43c0a1 100644 --- a/.github/workflows/mutations.yml +++ b/.github/workflows/mutations.yml @@ -33,7 +33,7 @@ jobs: tool: cargo-mutants - name: Mutants run: | - cargo mutants --no-shuffle -vV --exclude "cli/**" --in-diff git.diff -- --all-targets --all-features + cargo mutants --no-shuffle -vV --exclude "cli/**" --in-diff git.diff --cargo-arg=--all-features -- --all-targets - name: Archive mutants.out uses: actions/upload-artifact@v4 if: always()