From 52a028c8b78e3f33c1fdf5bc6af89d018a7d8a97 Mon Sep 17 00:00:00 2001 From: fanquake Date: Tue, 3 Nov 2026 14:04:21 +0000 Subject: [PATCH 1/3] gen: make AccessorType static [4/62] Building CXX object CMakeFiles/mpgen.dir/src/mp/gen.cpp.o libmultiprocess/src/mp/gen.cpp:208:13: warning: no previous prototype for function 'AccessorType' [-Wmissing-prototypes] 208 | std::string AccessorType(kj::StringPtr base_name, const Field& field) | ^ libmultiprocess/src/mp/gen.cpp:208:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 208 | std::string AccessorType(kj::StringPtr base_name, const Field& field) | ^ | static 1 warning generated. --- src/mp/gen.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mp/gen.cpp b/src/mp/gen.cpp index 8d733a91..d99b97b7 100644 --- a/src/mp/gen.cpp +++ b/src/mp/gen.cpp @@ -205,7 +205,7 @@ struct FieldList } }; -std::string AccessorType(kj::StringPtr base_name, const Field& field) +static std::string AccessorType(kj::StringPtr base_name, const Field& field) { const auto& f = field.param_is_set ? field.param : field.result; const auto field_name = f.getProto().getName(); From 641c78ecacb44b06ff8524c1209fb89fab955abf Mon Sep 17 00:00:00 2001 From: fanquake Date: Tue, 3 Nov 2026 14:04:32 +0000 Subject: [PATCH 2/3] ci: add -Wmissing-prototypes to LLVM config --- ci/configs/llvm.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/configs/llvm.bash b/ci/configs/llvm.bash index 049dd09b..33163176 100644 --- a/ci/configs/llvm.bash +++ b/ci/configs/llvm.bash @@ -2,7 +2,7 @@ CI_DESC="CI job using LLVM-based libraries and tools (clang, libc++, clang-tidy, CI_DIR=build-llvm NIX_ARGS=(--arg enableLibcxx true) export CXX=clang++ -export CXXFLAGS="-Werror -Wall -Wextra -Wextra-semi -Wpedantic -Wundef -Wthread-safety -Wunused -Wunused-const-variable -Wno-c++23-lambda-attributes" +export CXXFLAGS="-Werror -Wall -Wextra -Wextra-semi -Wmissing-prototypes -Wpedantic -Wundef -Wthread-safety -Wunused -Wunused-const-variable -Wno-c++23-lambda-attributes" CMAKE_ARGS=( -G Ninja -DMP_ENABLE_CLANG_TIDY=ON From c8ca0c0f6f1978eb65ff69d565d0a0e0753554ec Mon Sep 17 00:00:00 2001 From: fanquake Date: Tue, 3 Nov 2026 16:29:12 +0000 Subject: [PATCH 3/3] ci: add -Wmissing-declarations to default.bash --- ci/configs/default.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/configs/default.bash b/ci/configs/default.bash index 5cce6d3c..433f3e0c 100644 --- a/ci/configs/default.bash +++ b/ci/configs/default.bash @@ -1,5 +1,5 @@ CI_DESC="CI job using default libraries and tools, and running IWYU" CI_DIR=build-default -export CXXFLAGS="-Werror -Wall -Wextra -Wpedantic -Wundef -Wunused -Wunused-const-variable -Wextra-semi -Wmissing-noreturn -Wtrailing-whitespace" +export CXXFLAGS="-Werror -Wall -Wextra -Wpedantic -Wundef -Wunused -Wunused-const-variable -Wextra-semi -Wmissing-declarations -Wmissing-noreturn -Wtrailing-whitespace" CMAKE_ARGS=(-DMP_ENABLE_IWYU=ON) BUILD_ARGS=(-k)