From 33b82d161211b5a4c694afc4abbea639051804e8 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 1 Sep 2026 09:41:34 +0000 Subject: [PATCH] fix(build): make srcmorph/pom.xml parseable again main does not build at all -- not because of the unpublished 5.2.0 dependency, but because the POM is not well-formed XML: Non-parseable POM .../srcmorph/pom.xml: in comment after two dashes (--) next character must be > not f (position: END_TAG seen ... (--f... @54:73) XML forbids '--' inside a comment. The llama.version rationale I added in 5b4abeb spelled the CLI flags with their leading dashes (--flash-attn, --tensor-read-lazy, --lazy-mode) and used an em-dash-as-two-hyphens, four occurrences in one comment block. Maven cannot even read the project, so every goal fails before dependency resolution is reached -- which is why this hid behind the expected 5.2.0 failure. The flags are named without the leading dashes and the punctuation dash is replaced by a semicolon; no wording is lost. Verified: all four reactor POMs now have no '--' inside any comment (checked by regex over every block, not by eye), the file parses under a strict XML parser, and 'mvn validate' exits 0. My own miss: 5b4abeb edited a POM and I pushed it without running a single Maven command against it. --- srcmorph/pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/srcmorph/pom.xml b/srcmorph/pom.xml index 686a400..c65519b 100644 --- a/srcmorph/pom.xml +++ b/srcmorph/pom.xml @@ -51,13 +51,13 @@ SPDX-License-Identifier: Apache-2.0 InferenceParameters, ModelParameters, ChatResponse/Timings/Pair, ChatResponseParser, ReasoningFormat) is untouched by 5.1.0. 5.2.0 is a BREAKING bump this module needs, not an optional one: the binding removed - ModelParameters.enableFlashAttn()/ModelFlag.FLASH_ATTN (--flash-attn takes a mandatory + ModelParameters.enableFlashAttn()/ModelFlag.FLASH_ATTN (the flash-attn flag takes a mandatory on|off|auto value since llama.cpp b10273, so the valueless flag emitted a broken argv) and renamed setTensorReadLazy/TensorReadLazyMode to setLazyMode/LazyMode (llama.cpp - b10731 renamed --tensor-read-lazy to --lazy-mode with no alias). The provider calls + b10731 renamed the tensor-read-lazy flag to lazy-mode with no alias). The provider calls both, so it cannot compile against 5.1.0 any more. This deliberately names the RELEASE, not 5.2.0-SNAPSHOT: a snapshot would need a - entry for the Central snapshot channel (this repo declares none -- the + entry for the Central snapshot channel (this repo declares none; the distributionManagement/snapshotRepository below is deploy-only) AND would block every srcmorph release, since Central rejects a release with a -SNAPSHOT dependency. The build therefore stays red until net.ladenthin:llama:5.2.0 is published, and goes green