From 115ce74775276a7c60035c73b1f0e8d4fd9fff7d Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 1 Sep 2026 09:23:17 +0000 Subject: [PATCH] fix(build): keep the OCP suppression list in step with the renamed setters The Publish run on main fails its SpotBugs gate with two OCP_OVERLY_CONCRETE_PARAMETER findings, both introduced by #408: setFlashAttn(FlashAttn): 1st parameter 'mode' could be declared as CliArg setLazyMode(LazyMode): 1st parameter 'mode' could be declared as CliArg Widening either to CliArg is exactly what the surrounding comment says must not happen -- setFlashAttn(CacheType.Q8_0) would then compile and emit a nonsense CLI value the native code rejects at runtime. So these belong in the existing design-intent suppression, not in the code. The block lists methods by name, which makes it silently wrong after a rename: #408 renamed setTensorReadLazy to setLazyMode, so that entry has been matching nothing since, while the new setLazyMode and setFlashAttn were never covered. Both are added and the dead entry dropped. Not caught before the merge because spotbugs:check binds to verify, so neither mvn test nor mvn package runs it -- the same gap that produced the equivalent miss in srcmorph. Verified here with the exact command the CI job runs: mvn -B -f llama/pom.xml -DskipTests -Denforcer.skip=true compile spotbugs:check -> BugInstance size is 0, BUILD SUCCESS. --- llama/spotbugs-exclude.xml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/llama/spotbugs-exclude.xml b/llama/spotbugs-exclude.xml index 95d2e275..0644b2f4 100644 --- a/llama/spotbugs-exclude.xml +++ b/llama/spotbugs-exclude.xml @@ -59,8 +59,8 @@ SPDX-License-Identifier: MIT