Skip to content

Commit 8f68de9

Browse files
nglevinluispadron
authored andcommitted
Update builtin_objc_strip_action usage
Cherry-pick: a60c5ca
1 parent 55d3352 commit 8f68de9

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

apple/internal/partials/debug_symbols.bzl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -384,13 +384,13 @@ def _bundle_dsym_files(
384384
if not dsym_inputs:
385385
return [], None
386386

387-
# The dSYM binary file names are expected to match the unstripped binaries that they were based
388-
# on from the original crosstool dsymutil invocation; this is more imperative to get right when
389-
# referencing dSYM binaries from a dSYM bundle.
387+
# The name of the main binary is currently contingent on the Objective-C fragment's
388+
# `builtin_objc_strip_action` attribute, which determines *how* the unstripped binary is
389+
# named as an artifact.
390390
main_binary_basename = outputs.main_binary_basename(
391391
cpp_fragment = platform_prerequisites.cpp_fragment,
392392
bundle_name = bundle_name,
393-
unstripped = True,
393+
unstripped = platform_prerequisites.objc_fragment.builtin_objc_strip_action,
394394
)
395395

396396
command_inputs = dsym_inputs.values()

0 commit comments

Comments
 (0)