Skip to content

Commit 7ce968d

Browse files
Fix bazel run for applications when devicectl returns incomplete data (#2769)
Signed-off-by: Brentley Jones <github@brentleyjones.com>
1 parent 56b14ea commit 7ce968d

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

apple/internal/templates/apple_device.template.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,15 +94,15 @@ def identifier(self) -> str:
9494

9595
@property
9696
def udid(self) -> str:
97-
return self.hardware_properties["udid"]
97+
return self.hardware_properties.get("udid", "unknown")
9898

9999
@property
100100
def device_type(self) -> str:
101-
return self.hardware_properties["deviceType"]
101+
return self.hardware_properties.get("deviceType", "unknown")
102102

103103
@property
104104
def os_version_number(self) -> str:
105-
return self.device_properties["osVersionNumber"]
105+
return self.device_properties.get("osVersionNumber", "unknown")
106106

107107
@property
108108
def is_apple_tv(self) -> bool:
@@ -405,7 +405,7 @@ def run_app(
405405
device_identifier,
406406
app_path
407407
],
408-
check=True
408+
check=True,
409409
)
410410
app_bundle_id = bundle_id(app_path)
411411
launch_args = shlex.split(

0 commit comments

Comments
 (0)