Commit 55f6ece
authored
Infer tvOS/watchOS archs from the CPU parameters, similarly to iOS (#2707)
iOS currently has some special logic in `transition_support.bzl` that
defaults the architecture to the value of `//command_line_option:cpu` if
the value is iOS related (or a arm64 mac), but the same was not being
done for other platforms. This was causing some confusion on our team as
although on one end the regular iOS builds were being automatically
resolved to arm64 simulator builds, on the other end everything else was
resolving to x86_64 despite no changes in the environment.
This PR adds this same special logic to tvOS/watchOS for make them
consistent with iOS. So in my case, building tvOS from a arm64 mac would
now result in a tvOS arm64 simulator build.
It's unclear to me if the iOS case was done just to support some legacy
use-case (meaning we should probably not do this for the other
platforms), so if that's the case, let me know how to best solve this!1 parent 46d6c2a commit 55f6ece
1 file changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
248 | 253 | | |
249 | 254 | | |
250 | 255 | | |
251 | 256 | | |
252 | 257 | | |
253 | 258 | | |
254 | 259 | | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
255 | 265 | | |
256 | 266 | | |
257 | 267 | | |
| |||
0 commit comments