Skip to content

Commit 19dc0c5

Browse files
nglevinluispadron
authored andcommitted
Lower the test mismatch warning/error threshold to above iOS 16.9.
Cherry-pick: ef179c2
1 parent 0967279 commit 19dc0c5

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

apple/internal/testing/apple_test_bundle_support.bzl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,10 @@ _DEFAULT_TEST_BUNDLE_ID = "com.bazelbuild.rulesapple.Tests"
9898
# visible error messaging.
9999
_TEST_BUNDLE_NAME_SUFFIX = ".__internal__.__test_bundle"
100100

101-
# The lowest minimum OS version that can be used for the test mismatch warning. Higher versions will
102-
# be "fail"ed instead of issuing a warning to help enforce the minimum OS version to be the same
103-
# between the test bundle and test host, to avoid debugging issues and redundant build activity.
104-
_LOWEST_MINIMUM_OS_VERSION_FOR_TEST_MISMATCH_WARNING = "17.4"
101+
# The highest minimum OS version that can be used for the test mismatch warning. Higher versions
102+
# will be "fail"ed instead of issuing a warning to help enforce the minimum OS version to be the
103+
# same between the test bundle and test host to avoid debugging issues and redundant build activity.
104+
_HIGHEST_MINIMUM_OS_VERSION_FOR_TEST_MISMATCH_WARNING = "16.9"
105105

106106
_ERROR_ON_IOS_TEST_BUNDLE_MISMATCH_PACKAGE_PREFIXES = []
107107

@@ -320,7 +320,7 @@ Please assign "{rule_attribute_name}" a value of {test_host_rule_attribute} on t
320320
# TODO(b/337080510): Apply this failure case to all Apple platforms.
321321
if platform_prerequisites.platform_type != "ios" or (
322322
apple_common.dotted_version(test_min_os) > apple_common.dotted_version(
323-
_LOWEST_MINIMUM_OS_VERSION_FOR_TEST_MISMATCH_WARNING,
323+
_HIGHEST_MINIMUM_OS_VERSION_FOR_TEST_MISMATCH_WARNING,
324324
) or any([
325325
test_label_package_name.startswith(package_prefix)
326326
for package_prefix in _ERROR_ON_IOS_TEST_BUNDLE_MISMATCH_PACKAGE_PREFIXES

test/starlark_tests/common.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ _min_os_ios = struct(
4040
oldest_supported = "11.0",
4141
nplus1 = "13.0",
4242
stable_swift_abi = "12.2",
43-
test_mismatch_high_threshold = "18.0",
43+
test_mismatch_high_threshold = "17.0",
4444
widget_configuration_intents_support = "16.0",
4545
)
4646

0 commit comments

Comments
 (0)