Skip to content

Commit 0158abf

Browse files
authored
environment_plist: lower the entire --platform string (#2765)
The `xcrun --sdk` argument expects only lowercase letters and numbers. SDK version is usually just numbers, but in the exceptional case where it also has letters, we need to .lower() the entire string that we pass, and not just the platform name. We're slightly modifying `_environment_plist_impl()` in that commit to support that use-case.
1 parent ecb76e2 commit 0158abf

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

apple/internal/environment_plist.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def _environment_plist_impl(ctx):
7070
apple_fragment = platform_prerequisites.apple_fragment,
7171
arguments = [
7272
"--platform",
73-
platform.name_in_plist.lower() + str(sdk_version),
73+
(platform.name_in_plist + str(sdk_version)).lower(),
7474
"--output",
7575
ctx.outputs.plist.path,
7676
],

0 commit comments

Comments
 (0)