Fix android_application referencing unused bundle_keystore_properties.tmpl file.

Fixes #326

PiperOrigin-RevId: 806366660
Change-Id: I577401767420375a487fdf5143aec44fcf2a5049

Author: ahumesky

.bazelci/presubmit.yml

@@ -158,6 +158,7 @@ tasks:
       <<: *rules_flags
     build_targets:
       - "//java/com/basicapp:basic_app"
+      - "//java/com/basicapp:basic_app_bundle"
   basicapp_bzlmod:
     name: "Basic app bzlmod"
     platform: ${{ platform }}
@@ -169,6 +170,7 @@ tasks:
       ? "--enable_workspace=false"
     build_targets:
       - "//java/com/basicapp:basic_app"
+      - "//java/com/basicapp:basic_app_bundle"
   windows_basicapp:
     name: "Basic app windows"
     platform: "windows"
@@ -178,6 +180,7 @@ tasks:
       <<: *rules_flags
     build_targets:
       - "//java/com/basicapp:basic_app"
+      - "//java/com/basicapp:basic_app_bundle"
   windows_basicapp_bzlmod:
     name: "Basic app windows bzlmod"
     platform: "windows"
@@ -189,4 +192,5 @@ tasks:
       ? "--enable_workspace=false"
     build_targets:
       - "//java/com/basicapp:basic_app"
+      - "//java/com/basicapp:basic_app_bundle"
 

examples/basicapp/java/com/basicapp/BUILD

@@ -1,4 +1,9 @@
-load("@rules_android//android:rules.bzl", "android_binary", "android_library")
+load(
+    "@rules_android//android:rules.bzl",
+     "android_binary",
+     "android_library",
+     "android_application",
+)
 
 android_binary(
     name = "basic_app",
@@ -12,3 +17,15 @@ android_library(
     manifest = "AndroidManifest.xml",
     resource_files = glob(["res/**"]),
 )
+
+android_application(
+    name = "basic_app_bundle",
+    # bundle_config_file or feature_modules must be specified to get an aab
+    bundle_config_file = "bundle_config.pb.json",
+    manifest = "AndroidManifest.xml",
+    manifest_values = {
+        "applicationId": "com.basicapp",
+        "versionCode": "1",
+    },
+    deps = [":basic_lib"],
+)

examples/basicapp/java/com/basicapp/bundle_config.pb.json

@@ -0,0 +1,12 @@
+// https://github.com/google/bundletool/blob/master/src/main/proto/config.proto
+{
+  "optimizations": {
+    "splitsConfig": {
+      "splitDimension": [
+        {
+          "value": "LANGUAGE"
+        }
+      ]
+    }
+  }
+}

examples/basicapp/java/com/basicapp/res/values-b+es/strings.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <string name="hello_world" translatable="false">¡Hola Mundo!</string>
+</resources>

kokoro/presubmit/presubmit_main.sh

@@ -152,7 +152,8 @@ function main() {
     "${COMMON_ARGS[@]}" \
     "${RULE_ARGS[@]}" \
     -- \
-    //java/com/basicapp:basic_app
+    //java/com/basicapp:basic_app \
+    //java/com/basicapp:basic_app_bundle
 
   # Mobile-install test with no deployment
   "$bazel" mobile-install \

rules/android_application/attrs.bzl

@@ -71,10 +71,6 @@ ANDROID_APPLICATION_ATTRS = _attrs.add(
             allow_single_file = True,
             default = ":bundle_deploy.sh_template",
         ),
-        _bundle_keystore_properties = attr.label(
-            allow_single_file = True,
-            default = "//rules:bundle_keystore_properties.tmpl",
-        ),
         _feature_manifest_script = attr.label(
             allow_single_file = True,
             cfg = "exec",