Skip to content

Commit f2ec0c2

Browse files
ted-xiecopybara-github
authored andcommitted
Merge #406 by ted-xie: Migrate away from @bazel_tools//tools/jdk
Closes #406 COPYBARA_INTEGRATE_REVIEW=#406 from ted-xie:no_bazel_tools_jdk 1677235 PiperOrigin-RevId: 794723027 Change-Id: I12b0f1b975ed2d9f351e557d8883b93b3b58f5f8
1 parent 108de81 commit f2ec0c2

7 files changed

Lines changed: 20 additions & 15 deletions

File tree

mobile_install/dependency_map.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ versioned_deps = struct(
3333
head = "//tools/android:gen_fail",
3434
),
3535
jar_tool = struct(
36-
head = "@bazel_tools//tools/jdk:JavaBuilder_deploy.jar",
36+
head = "@remote_java_tools//:JavaBuilder",
3737
),
3838
res_v3_dummy_manifest = struct(
3939
head = "//rules:res_v3_dummy_AndroidManifest.xml",

rules/android_sdk_repository/helper.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ def create_android_sdk_rules(
224224
main_dex_list_creator = ":main_dex_list_creator",
225225
proguard = select({
226226
":disallow_proguard": ":fail",
227-
"//conditions:default": "@bazel_tools//tools/jdk:proguard",
227+
"//conditions:default": "@remote_java_tools//:proguard",
228228
}),
229229
# See https://github.com/bazelbuild/bazel/issues/8757
230230
tags = ["__ANDROID_RULES_MIGRATION__"],

src/java/com/example/sampleapp/BUILD

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,24 +29,28 @@ android_library(
2929
# JNI target.
3030
genrule(
3131
name = "jni_h",
32-
srcs = ["@bazel_tools//tools/jdk:jni_header"],
32+
srcs = ["@rules_java//toolchains:jni_header"],
3333
outs = [":jni.h"],
3434
cmd = "cp $< $@",
3535
)
3636

3737
genrule(
3838
name = "jni_md_h",
3939
srcs = select({
40-
"//conditions:default":["@bazel_tools//tools/jdk:jni_md_header-linux"],
41-
"@platforms//os:windows": ["@bazel_tools//tools/jdk:jni_md_header-windows"],
42-
"@platforms//os:macos": ["@bazel_tools//tools/jdk:jni_md_header-darwin"],
40+
"//conditions:default": ["@rules_java//toolchains:jni_md_header-linux"],
41+
"@platforms//os:windows": ["@rules_java//toolchains:jni_md_header-windows"],
42+
"@platforms//os:macos": ["@rules_java//toolchains:jni_md_header-darwin"],
4343
}),
4444
outs = [":jni_md.h"],
4545
cmd = "cp $< $@",
4646
)
4747

4848
cc_library(
4949
name = "native",
50-
srcs = ["native.c", ":jni.h", ":jni_md.h"],
50+
srcs = [
51+
"native.c",
52+
":jni.h",
53+
":jni_md.h",
54+
],
5155
includes = ["."],
5256
)

src/tools/javatests/com/google/devtools/build/android/dexer/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ java_library(
3939
":dexbuilder_import",
4040
"//src/tools/java/com/google/devtools/build/android/dexer:DexFileSplitter_lib",
4141
"//src/tools/java/com/google/devtools/build/android/r8:dexbuilder_deploy.jar",
42-
"@bazel_tools//tools/java/runfiles",
4342
"@rules_android_maven//:com_google_guava_guava",
4443
"@rules_android_maven//:com_google_truth_truth",
4544
"@rules_android_maven//:junit_junit",
4645
"@rules_android_maven//:org_mockito_mockito_core",
46+
"@rules_java//java/runfiles",
4747
],
4848
)
4949

src/tools/javatests/com/google/devtools/build/android/r8/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ java_library(
3030
}),
3131
deps = [
3232
"//src/tools/java/com/google/devtools/build/android/r8",
33-
"@bazel_tools//tools/java/runfiles",
3433
"@rules_android_maven//:com_android_tools_r8",
3534
"@rules_android_maven//:com_beust_jcommander",
3635
"@rules_android_maven//:com_google_guava_guava",
3736
"@rules_android_maven//:com_google_truth_truth",
3837
"@rules_android_maven//:junit_junit",
38+
"@rules_java//java/runfiles",
3939
],
4040
)
4141

toolchains/android/toolchain.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ _ATTRS = dict(
256256
executable = True,
257257
),
258258
testsupport = attr.label(
259-
default = "@bazel_tools//tools/jdk:TestRunner",
259+
default = Label("//tools/jdk:TestRunner"),
260260
),
261261
unzip_tool = attr.label(
262262
cfg = "exec",

tools/jdk/BUILD

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
load("@rules_java//java:java_import.bzl", "java_import")
12
load("@rules_java//toolchains:default_java_toolchain.bzl", "default_java_toolchain")
23
load("@rules_shell//shell:sh_binary.bzl", "sh_binary")
34
load("@rules_shell//shell:sh_test.bzl", "sh_test")
@@ -119,14 +120,14 @@ alias(
119120
)
120121

121122
alias(
122-
name = "jdk",
123-
actual = "@bazel_tools//tools/jdk:jdk",
123+
name = "current_host_java_runtime",
124+
actual = "@rules_java//toolchains:current_host_java_runtime",
124125
visibility = ["//visibility:public"],
125126
)
126127

127-
alias(
128-
name = "current_host_java_runtime",
129-
actual = "@rules_java//toolchains:current_host_java_runtime",
128+
java_import(
129+
name = "TestRunner",
130+
jars = ["@remote_java_tools//:Runner"],
130131
visibility = ["//visibility:public"],
131132
)
132133

0 commit comments

Comments
 (0)