Skip to content

Inconsistent Handling of Config ID in Benchmark Class #5

Description

@LabChameleon

Hi Everyone,

the config_id is handled inconsistently in the query and get_config method. In the former it is converted into a string and in the latter it is not.

Please compare:

LCBench/api.py

Lines 31 to 39 in 17e6375

def query(self, dataset_name, tag, config_id):
"""Query a run.
Keyword arguments:
dataset_name -- str, the name of the dataset in the benchmark
tag -- str, the tag you want to query
config_id -- int, an identifier for which run you want to query, if too large will query the last run
"""
config_id = str(config_id)

versus

LCBench/api.py

Lines 108 to 112 in 17e6375

def get_config(self, dataset_name, config_id):
"""Returns the configuration of a run specified by dataset name and config id"""
if dataset_name not in self.dataset_names:
raise ValueError("Dataset name not found.")
return self.data[dataset_name][config_id]["config"]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions