fix: fix the default parameter issues

aminya · aminya · commit fea6cc58d254 · 2023-09-07T12:13:27.000-07:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,4 +1,4 @@
 {
   "extends": "eslint-config-atomic",
-  "ignorePatterns": ["dist/", "node_modules/"]
+  "ignorePatterns": ["dist/", "node_modules/", "coverage/"]
 }
diff --git a/package.json b/package.json
@@ -17,7 +17,7 @@
   "license": "MIT",
   "scripts": {
     "build": "tsc",
-    "prepare": "npm run build",
+    "prepublishOnly": "npm run build",
     "format": "prettier --write .",
     "test.format": "prettier . --check",
     "lint": "eslint . --fix",
diff --git a/src/get-terserrc.ts b/src/get-terserrc.ts
@@ -1,4 +1,4 @@
-export function getTerserOptions(NODE_ENV: string = "production", BABEL_ENV?: string) {
+export function getTerserOptions(NODE_ENV: string = "production", BABEL_ENV: string | undefined = undefined) {
   const isDev = NODE_ENV === "development"
   const isTest = NODE_ENV === "test"
   const isReadable = isDev || isTest

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "eslint-config-atomic",`
`3`		`- "ignorePatterns": ["dist/", "node_modules/"]`
	`3`	`+ "ignorePatterns": ["dist/", "node_modules/", "coverage/"]`
`4`	`4`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-export function getTerserOptions(NODE_ENV: string = "production", BABEL_ENV?: string) {`
	`1`	`+export function getTerserOptions(NODE_ENV: string = "production", BABEL_ENV: string \| undefined = undefined) {`
`2`	`2`	`const isDev = NODE_ENV === "development"`
`3`	`3`	`const isTest = NODE_ENV === "test"`
`4`	`4`	`const isReadable = isDev \|\| isTest`