From 8b0022613000153eb43d90617943c54eff264fa5 Mon Sep 17 00:00:00 2001 From: Derrick Austin Date: Fri, 12 Jun 2026 22:44:12 -0400 Subject: [PATCH 1/2] ci: test on PHP 8.4 and 8.5 and update Node 20 actions Adds 8.4 and 8.5 to the unit test matrix, now that #45 and #47 have cleaned up Assetic's own deprecations on those versions. The only deprecations remaining on 8.4/8.5 originate in vendor code (Twig 2.x and ScssPhp 1.x) that Assetic cannot fix, so the symfony/phpunit-bridge deprecation helper is configured to tolerate indirect (vendor-internal) deprecations while still failing the build on any deprecation in Assetic's own code (max[self]=0&max[direct]=0). The full suite passes on 8.4 and 8.5 (408 tests, 547 assertions). Also bumps the actions pinned to the deprecated Node 20 runtime to their Node 24 releases: actions/checkout v4 -> v5 and supplypike/setup-bin v4 -> v5. shivammathur/setup-php@v2 already runs on Node 24, so it is left unchanged. --- .github/workflows/code-quality.yml | 2 +- .github/workflows/tests.yml | 6 +++--- phpunit.xml.dist | 1 + 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml index 5cf8091..ac69a38 100644 --- a/.github/workflows/code-quality.yml +++ b/.github/workflows/code-quality.yml @@ -12,7 +12,7 @@ jobs: name: Code Quality steps: - name: Checkout changes - uses: actions/checkout@v4 + uses: actions/checkout@v5 with: fetch-depth: 0 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 32c83fc..146db89 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -11,13 +11,13 @@ jobs: strategy: max-parallel: 6 matrix: - phpVersion: ['7.3', '7.4', '8.0', '8.1', '8.2', '8.3'] + phpVersion: ['7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5'] fail-fast: false runs-on: ubuntu-latest name: Linux / PHP ${{ matrix.phpVersion }} steps: - name: Checkout changes - uses: actions/checkout@v4 + uses: actions/checkout@v5 - name: Install NPM dependencies run: | @@ -25,7 +25,7 @@ jobs: npm install - name: Install Tailwind CSS Standalone CLI - uses: supplypike/setup-bin@v4 + uses: supplypike/setup-bin@v5 with: uri: 'https://github.com/tailwindlabs/tailwindcss/releases/download/v3.4.4/tailwindcss-linux-x64' name: 'tailwindcss' diff --git a/phpunit.xml.dist b/phpunit.xml.dist index ea9c6ce..0d78658 100644 --- a/phpunit.xml.dist +++ b/phpunit.xml.dist @@ -12,5 +12,6 @@ + From 7eacc91f435d43df1d6e360175ecfea2839efd20 Mon Sep 17 00:00:00 2001 From: Ben Thomson Date: Mon, 15 Jun 2026 05:11:31 +0000 Subject: [PATCH 2/2] Update to more recent versions Co-authored-by: Ben Thomson --- .github/workflows/code-quality.yml | 2 +- .github/workflows/tests.yml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml index ac69a38..1ce3d70 100644 --- a/.github/workflows/code-quality.yml +++ b/.github/workflows/code-quality.yml @@ -12,7 +12,7 @@ jobs: name: Code Quality steps: - name: Checkout changes - uses: actions/checkout@v5 + uses: actions/checkout@v6 with: fetch-depth: 0 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 146db89..84c653d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -17,7 +17,7 @@ jobs: name: Linux / PHP ${{ matrix.phpVersion }} steps: - name: Checkout changes - uses: actions/checkout@v5 + uses: actions/checkout@v6 - name: Install NPM dependencies run: | @@ -27,9 +27,9 @@ jobs: - name: Install Tailwind CSS Standalone CLI uses: supplypike/setup-bin@v5 with: - uri: 'https://github.com/tailwindlabs/tailwindcss/releases/download/v3.4.4/tailwindcss-linux-x64' + uri: 'https://github.com/tailwindlabs/tailwindcss/releases/download/v4.3.1/tailwindcss-linux-x64' name: 'tailwindcss' - version: '3.4.4' + version: '4.3.1' - name: Install PHP uses: shivammathur/setup-php@v2