From cc5b3cfd15bae1c19193e655779690456589bf46 Mon Sep 17 00:00:00 2001 From: Mahdi Ashrafee Date: Sat, 26 Sep 2026 14:39:33 -0400 Subject: [PATCH] Fix pylint warnings in tests --- tests/conftest.py | 10 +++++----- tests/test_rate_limit.py | 4 ++-- tests/test_risk.py | 7 +++---- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/tests/conftest.py b/tests/conftest.py index 3b15069..3ae0c02 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -1,14 +1,14 @@ import sys from unittest.mock import MagicMock -# Prevent network calls from whisper model initialization during local execution -sys.modules["whisper"] = MagicMock() - -from fastapi.testclient import TestClient import fakeredis import pytest +from fastapi.testclient import TestClient + +# Prevent network calls from whisper model initialization during local execution +sys.modules["whisper"] = MagicMock() -from app.main import app +from app.main import app # pylint: disable=wrong-import-position @pytest.fixture diff --git a/tests/test_rate_limit.py b/tests/test_rate_limit.py index 62ee77a..671f3dc 100644 --- a/tests/test_rate_limit.py +++ b/tests/test_rate_limit.py @@ -41,7 +41,7 @@ def test_exhausted_quota_resets_after_configured_window(mock_redis, mock_time): @patch("app.services.rate_limit.time.time", return_value=1_000.0) @patch("app.services.rate_limit.r") -def test_configured_window_is_honored(mock_redis, mock_time, monkeypatch): +def test_configured_window_is_honored(mock_redis, _mock_time, monkeypatch): monkeypatch.setattr(rate_limit_mod, "RATE_LIMIT_WINDOW", 30) # 31 seconds ago is outside a 30s window, so the quota should reset. @@ -55,7 +55,7 @@ def test_configured_window_is_honored(mock_redis, mock_time, monkeypatch): assert rate_limit_mod.check_rate_limit("203.0.113.12") is False mock_redis.hset.assert_not_called() - + @patch("app.services.rate_limit.time.time", return_value=1_000.0) @patch("app.services.rate_limit.r") def test_check_rate_limit_key_has_expiry(mock_redis, mock_time): diff --git a/tests/test_risk.py b/tests/test_risk.py index df344bf..e9e3d4b 100644 --- a/tests/test_risk.py +++ b/tests/test_risk.py @@ -1,10 +1,9 @@ import os +from unittest.mock import patch os.environ.setdefault("DEEPSEEK_API_KEY", "test-key") -from unittest.mock import patch - -from app.services.risk import get_assessment +from app.services.risk import get_assessment # pylint: disable=wrong-import-position VALID_RESPONSE = { @@ -42,4 +41,4 @@ def test_get_assessment_returns_none_after_all_attempts_fail(): result = get_assessment("test transcription") assert result is None - assert mock_ask.call_count == 5 \ No newline at end of file + assert mock_ask.call_count == 5