Add upsert regression test for non-join partition changes#3409
Open
ndrluis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While reviewing #3387, I found a missing regression test for upsert behavior when a table is partitioned by a column that is not part of
join_cols, and the source row changes that partition column value.For example, if the table is partitioned by
order_datebut the upsert matches rows using onlyorder_id, an existing row should still be matched byorder_ideven when the incoming row has a differentorder_date. The expected behavior is that the row is updated and moved to the new partition, not treated as a new insert.Regardless of whether #3387 is merged, I believe this behavior should be protected in the repository because partition pruning optimizations in this area can otherwise accidentally prune away the existing target row before the join-key match is evaluated.