REST: Allow Identifier type in drop_view method#3408
Merged
Conversation
ndrluis
approved these changes
May 24, 2026
kevinjqliu
approved these changes
May 24, 2026
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM
regex searched with "for "identifier: str" but not followed by | " (identifier:\s*str(?!\s*\|))
this is the only occurrence under catalog/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix the warning message in the IDE.
The base class and other classes use the
str | Identifierstyle in thedrop_viewmethod.I also confirmed that other methods in the REST catalog class use
str | Identifierfor identifiers.Are these changes tested?
N/A
Are there any user-facing changes?
No