Skip to content

Commit 940a8ca

Browse files
committed
Bigtable: clean up client side metrics flag
1 parent eba1ec3 commit 940a8ca

1 file changed

Lines changed: 0 additions & 13 deletions

File tree

sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceFactory.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ class BigtableServiceFactory implements Serializable {
5151
private static final ConcurrentHashMap<UUID, AtomicInteger> refCounts = new ConcurrentHashMap<>();
5252
private static final Object lock = new Object();
5353

54-
private static final String BIGTABLE_ENABLE_CLIENT_SIDE_METRICS =
55-
"bigtable_enable_client_side_metrics";
56-
5754
private static final String BIGTABLE_ENABLE_SKIP_LARGE_ROWS = "bigtable_enable_skip_large_rows";
5855

5956
@AutoValue
@@ -130,11 +127,6 @@ BigtableServiceEntry getServiceForReading(
130127
BigtableConfigTranslator.translateReadToVeneerSettings(
131128
config, opts, optsFromBigtableOptions, pipelineOptions);
132129

133-
if (ExperimentalOptions.hasExperiment(pipelineOptions, BIGTABLE_ENABLE_CLIENT_SIDE_METRICS)) {
134-
LOG.info("Enabling client side metrics");
135-
BigtableDataSettings.enableBuiltinMetrics();
136-
}
137-
138130
boolean skipLargeRows =
139131
ExperimentalOptions.hasExperiment(pipelineOptions, BIGTABLE_ENABLE_SKIP_LARGE_ROWS);
140132

@@ -181,11 +173,6 @@ BigtableServiceEntry getServiceForWriting(
181173
BigtableConfigTranslator.translateWriteToVeneerSettings(
182174
config, opts, optsFromBigtableOptions, pipelineOptions);
183175

184-
if (ExperimentalOptions.hasExperiment(pipelineOptions, BIGTABLE_ENABLE_CLIENT_SIDE_METRICS)) {
185-
LOG.info("Enabling client side metrics");
186-
BigtableDataSettings.enableBuiltinMetrics();
187-
}
188-
189176
BigtableService service = new BigtableServiceImpl(settings);
190177
entry = BigtableServiceEntry.create(configId, service);
191178
entries.put(configId.id(), entry);

0 commit comments

Comments
 (0)