Fix Prism global window side input visibility in GetSideData (#38067)

aIbrahiim · web-flow · commit 718ff4ec15d2 · 2026-04-04T21:17:27.000-04:00
* Fix Prism global window side input visibility in GetSideData

* use else if for GetSideData
diff --git a/sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go b/sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go
@@ -1707,7 +1707,9 @@ func (ss *stageState) GetSideData(tID, inputID string, watermark mtime.Time) map
 	d := ss.sideInputs[LinkID{Transform: tID, Local: inputID}]
 	ret := map[typex.Window][][]byte{}
 	for win, ds := range d {
-		if win.MaxTimestamp() <= watermark {
+		if _, ok := win.(window.GlobalWindow); ok {
+			ret[win] = ds
+		} else if win.MaxTimestamp() <= watermark {
 			ret[win] = ds
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1707,7 +1707,9 @@ func (ss *stageState) GetSideData(tID, inputID string, watermark mtime.Time) map`
`1707`	`1707`	`d := ss.sideInputs[LinkID{Transform: tID, Local: inputID}]`
`1708`	`1708`	`ret := map[typex.Window][][]byte{}`
`1709`	`1709`	`for win, ds := range d {`
`1710`		`- if win.MaxTimestamp() <= watermark {`
	`1710`	`+ if _, ok := win.(window.GlobalWindow); ok {`
	`1711`	`+ ret[win] = ds`
	`1712`	`+ } else if win.MaxTimestamp() <= watermark {`
`1711`	`1713`	`ret[win] = ds`
`1712`	`1714`	`}`
`1713`	`1715`	`}`