feat: handle edge cases for stability

Author: anonrig

lib/parse.js

@@ -22,8 +22,8 @@ function parse(input) {
   for (let i = 0; i < input.length + 1; i++) {
     let c = input.charCodeAt(i);
 
-    // Handle '&' and end of line to pass the current values to result
-    if (c === 38 || isNaN(c)) {
+    // Handle '&', '#' and end of line to pass the current values to result
+    if (c === 38 || c === 35 || isNaN(c)) {
       // Disallow empty key values.
       if (equalityIndex - separatorIndex > 0 && i - equalityIndex + 1 > 0) {
         key = input.slice(separatorIndex, equalityIndex);
@@ -48,17 +48,28 @@ function parse(input) {
         }
       }
 
+      // Terminate loop when parser encounters '#'
+      if (c === 35) {
+        break;
+      }
+
       // Reset reading key value pairs
       separatorIndex = i + 1;
       equalityIndex = i + 1;
+      shouldEncode = false;
     }
-    // Handle equal operator
+    // Check '='
     else if (c === 61) {
       equalityIndex = i;
     }
     // Check '+', and replace it with empty space.
     else if (c === 43) {
       input[i] = " ";
+    }
+    // Check '?' in the beginning, and omit if exists
+    else if (c === 63 && i === 0) {
+      separatorIndex = 1;
+      equalityIndex = 1;
     } else {
       // Check '%' character for encoding
       if (c === 37) {

test/basics.test.ts

@@ -29,3 +29,16 @@ test("should parse the basics", () => {
 test("should throw error on invalid type", () => {
   assert.throws(() => qs.parse(5), "Invalid Input");
 });
+
+test("handles & on first/last character", () => {
+  assert.deepEqual(qs.parse("&hello=world"), { hello: "world" });
+  assert.deepEqual(qs.parse("hello=world&"), { hello: "world" });
+});
+
+test("handles ? on first character", () => {
+  assert.deepEqual(qs.parse("?hello=world"), { hello: "world" });
+});
+
+test("removes fragment from string", () => {
+  assert.deepEqual(qs.parse("foo=bar#hello"), { foo: "bar" });
+});