fix: make package consistent with native

Author: anonrig

README.md

@@ -12,8 +12,6 @@ npm i --save fast-querystring
 
 - Parsed object does not have prototype methods
 - Uses `&` separator as default
-- Removes fragment from string
-  - `foo=bar#hello=world` parses into `{foo: 'bar'}`
 - Supports only UTF-8
 - Supports only input of type `string`
 - Key & value with length 0 is omitted by default

lib/parse.js

@@ -17,18 +17,25 @@ function parse(input) {
   let separatorIndex = 0;
   let equalityIndex = 0;
   let shouldEncode = false;
+  let hasPlus = false;
 
   // Have a boundary of input.length + 1 to access last pair inside the loop.
   for (let i = 0; i < input.length + 1; i++) {
     let c = input.charCodeAt(i);
 
-    // Handle '&', '#' and end of line to pass the current values to result
+    // Handle '&' and end of line to pass the current values to result
     if (c === 38 || c === 35 || isNaN(c)) {
       // Disallow empty key values.
       if (equalityIndex - separatorIndex > 0 && i - equalityIndex + 1 > 0) {
         key = input.slice(separatorIndex, equalityIndex);
         value = input.slice(equalityIndex + 1, i);
 
+        // Optimization: Replace '+' with space
+        if (hasPlus) {
+          key = key.replace(/\+/g, " ");
+          value = value.replace(/\+/g, " ");
+        }
+
         // Optimization: Do not decode if it's not necessary.
         if (shouldEncode) {
           key = decodeURIComponent(key);
@@ -48,11 +55,6 @@ function parse(input) {
         }
       }
 
-      // Terminate loop when parser encounters '#'
-      if (c === 35) {
-        break;
-      }
-
       // Reset reading key value pairs
       separatorIndex = i + 1;
       equalityIndex = i + 1;
@@ -64,12 +66,7 @@ function parse(input) {
     }
     // Check '+', and replace it with empty space.
     else if (c === 43) {
-      input[i] = " ";
-    }
-    // Check '?' in the beginning, and omit if exists
-    else if (c === 63 && i === 0) {
-      separatorIndex = 1;
-      equalityIndex = 1;
+      hasPlus = true;
     } else {
       // Check '%' character for encoding
       if (c === 37) {

test/basics.test.ts

@@ -36,9 +36,12 @@ test("handles & on first/last character", () => {
 });
 
 test("handles ? on first character", () => {
-  assert.deepEqual(qs.parse("?hello=world"), { hello: "world" });
+  // This aligns with `node:querystring` functionality
+  assert.deepEqual(qs.parse("?hello=world"), { "?hello": "world" });
 });
 
-test("removes fragment from string", () => {
-  assert.deepEqual(qs.parse("foo=bar#hello"), { foo: "bar" });
+test("handles + character", () => {
+  assert.deepEqual(qs.parse("author=Yagiz+Nizipli"), {
+    author: "Yagiz Nizipli",
+  });
 });