Skip to content

Commit 6d58d89

Browse files
committed
fix: e2e test outdated
1 parent b75a27d commit 6d58d89

2 files changed

Lines changed: 5 additions & 11 deletions

File tree

packages/app/e2e/selectors.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,8 @@ export const settingsNotificationsAgentSelector = '[data-action="settings-notifi
2020
export const settingsNotificationsPermissionsSelector = '[data-action="settings-notifications-permissions"]'
2121
export const settingsNotificationsErrorsSelector = '[data-action="settings-notifications-errors"]'
2222
export const settingsSoundsAgentSelector = '[data-action="settings-sounds-agent"]'
23-
export const settingsSoundsAgentEnabledSelector = '[data-action="settings-sounds-agent-enabled"]'
2423
export const settingsSoundsPermissionsSelector = '[data-action="settings-sounds-permissions"]'
25-
export const settingsSoundsPermissionsEnabledSelector = '[data-action="settings-sounds-permissions-enabled"]'
2624
export const settingsSoundsErrorsSelector = '[data-action="settings-sounds-errors"]'
27-
export const settingsSoundsErrorsEnabledSelector = '[data-action="settings-sounds-errors-enabled"]'
2825
export const settingsUpdatesStartupSelector = '[data-action="settings-updates-startup"]'
2926
export const settingsReleaseNotesSelector = '[data-action="settings-release-notes"]'
3027

packages/app/e2e/settings/settings.spec.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {
99
settingsNotificationsPermissionsSelector,
1010
settingsReleaseNotesSelector,
1111
settingsSoundsAgentSelector,
12-
settingsSoundsAgentEnabledSelector,
1312
settingsSoundsErrorsSelector,
1413
settingsSoundsPermissionsSelector,
1514
settingsThemeSelector,
@@ -336,21 +335,19 @@ test("changing sound agent selection persists in localStorage", async ({ page, g
336335
expect(stored?.sounds?.agent).not.toBe("staplebops-01")
337336
})
338337

339-
test("disabling agent sound disables sound selection", async ({ page, gotoSession }) => {
338+
test("selecting none disables agent sound", async ({ page, gotoSession }) => {
340339
await gotoSession()
341340

342341
const dialog = await openSettings(page)
343342
const select = dialog.locator(settingsSoundsAgentSelector)
344-
const switchContainer = dialog.locator(settingsSoundsAgentEnabledSelector)
345343
const trigger = select.locator('[data-slot="select-select-trigger"]')
346344
await expect(select).toBeVisible()
347-
await expect(switchContainer).toBeVisible()
348345
await expect(trigger).toBeEnabled()
349346

350-
await switchContainer.locator('[data-slot="switch-control"]').click()
351-
await page.waitForTimeout(100)
352-
353-
await expect(trigger).toBeDisabled()
347+
await trigger.click()
348+
const items = page.locator('[data-slot="select-select-item"]')
349+
await expect(items.first()).toBeVisible()
350+
await items.first().click()
354351

355352
const stored = await page.evaluate((key) => {
356353
const raw = localStorage.getItem(key)

0 commit comments

Comments
 (0)