Skip to content

Commit 41aa254

Browse files
authored
fix(app): show review on the empty session route (#18251)
1 parent d178d82 commit 41aa254

1 file changed

Lines changed: 18 additions & 13 deletions

File tree

packages/app/src/pages/session.tsx

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ export default function Page() {
420420
const diffs = createMemo(() => (params.id ? (sync.data.session_diff[params.id] ?? []) : []))
421421
const sessionCount = createMemo(() => Math.max(info()?.summary?.files ?? 0, diffs().length))
422422
const hasSessionReview = createMemo(() => sessionCount() > 0)
423-
const canReview = createMemo(() => !!params.id)
423+
const canReview = createMemo(() => !!params.dir)
424424
const reviewTab = createMemo(() => isDesktop())
425425
const tabState = createSessionTabs({
426426
tabs,
@@ -1165,6 +1165,18 @@ export default function Page() {
11651165
</div>
11661166
)
11671167

1168+
const mobileReview = () =>
1169+
reviewContent({
1170+
diffStyle: "unified",
1171+
classes: {
1172+
root: "pb-8",
1173+
header: "px-4",
1174+
container: "px-4",
1175+
},
1176+
loadingClass: "px-4 py-4 text-text-weak",
1177+
emptyClass: "h-full pb-64 -mt-4 flex flex-col items-center justify-center text-center gap-6",
1178+
})
1179+
11681180
createEffect(
11691181
on(
11701182
activeFileTab,
@@ -1798,7 +1810,7 @@ export default function Page() {
17981810
<div class="relative bg-background-base size-full overflow-hidden flex flex-col">
17991811
<SessionHeader />
18001812
<div class="flex-1 min-h-0 flex flex-col md:flex-row">
1801-
<Show when={!isDesktop() && !!params.id}>
1813+
<Show when={!isDesktop() && canReview()}>
18021814
<Tabs value={store.mobileTab} class="h-auto">
18031815
<Tabs.List>
18041816
<Tabs.Trigger
@@ -1840,16 +1852,7 @@ export default function Page() {
18401852
<Show when={lastUserMessage()}>
18411853
<MessageTimeline
18421854
mobileChanges={mobileChanges()}
1843-
mobileFallback={reviewContent({
1844-
diffStyle: "unified",
1845-
classes: {
1846-
root: "pb-8",
1847-
header: "px-4",
1848-
container: "px-4",
1849-
},
1850-
loadingClass: "px-4 py-4 text-text-weak",
1851-
emptyClass: "h-full pb-64 -mt-4 flex flex-col items-center justify-center text-center gap-6",
1852-
})}
1855+
mobileFallback={mobileReview()}
18531856
actions={actions}
18541857
scroll={ui.scroll}
18551858
onResumeScroll={resumeScroll}
@@ -1881,7 +1884,9 @@ export default function Page() {
18811884
</Show>
18821885
</Match>
18831886
<Match when={true}>
1884-
<NewSessionView worktree={newSessionWorktree()} />
1887+
<Show when={mobileChanges()} fallback={<NewSessionView worktree={newSessionWorktree()} />}>
1888+
<div class="relative h-full overflow-hidden">{mobileReview()}</div>
1889+
</Show>
18851890
</Match>
18861891
</Switch>
18871892
</div>

0 commit comments

Comments
 (0)