From 87bed2a69f131c1b0778f1884d5d33286acb75af Mon Sep 17 00:00:00 2001 From: Alan Agius <17563226+alan-agius4@users.noreply.github.com> Date: Thu, 29 Oct 2026 15:22:49 +0000 Subject: [PATCH] test: re-enable rebuild-symlink and browser-webdriverio E2E tests --- .../unit-test/runners/vitest/browser-provider.ts | 7 ++++++- tests/e2e/tests/build/rebuild-symlink.ts | 13 +++++++------ tests/e2e/tests/vitest/browser-webdriverio.ts | 3 --- 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/packages/angular/build/src/builders/unit-test/runners/vitest/browser-provider.ts b/packages/angular/build/src/builders/unit-test/runners/vitest/browser-provider.ts index 069b0374d22d..8cc43f93424f 100644 --- a/packages/angular/build/src/builders/unit-test/runners/vitest/browser-provider.ts +++ b/packages/angular/build/src/builders/unit-test/runners/vitest/browser-provider.ts @@ -192,7 +192,12 @@ export async function setupBrowserConfiguration( if (instance.browser === 'chrome' || instance.browser === 'chromium') { instance.provider = providerFactory({ capabilities: { - 'goog:chromeOptions': { binary: executablePath }, + 'goog:chromeOptions': { + binary: executablePath, + args: executablePath.includes('rules_browsers') + ? ['--no-sandbox', '--disable-dev-shm-usage', '--disable-gpu'] + : undefined, + }, }, }); } diff --git a/tests/e2e/tests/build/rebuild-symlink.ts b/tests/e2e/tests/build/rebuild-symlink.ts index 2cbe41aded25..d06c1e559a5f 100644 --- a/tests/e2e/tests/build/rebuild-symlink.ts +++ b/tests/e2e/tests/build/rebuild-symlink.ts @@ -1,5 +1,6 @@ import { symlink } from 'node:fs/promises'; import { resolve } from 'node:path'; +import { setTimeout } from 'node:timers/promises'; import { appendToFile, expectFileToMatch, writeMultipleFiles } from '../../utils/fs'; import { execAndWaitForOutputToMatch, waitForAnyProcessOutputToMatch } from '../../utils/process'; import { updateJsonFile } from '../../utils/project'; @@ -10,11 +11,6 @@ const buildReadyRegEx = getGlobalVariable('argv')['esbuild'] : /Build at: /; export default async function () { - // TODO: Disabled pending investigation. Steps work outside of test - if (getGlobalVariable('argv')['esbuild']) { - return; - } - await updateJsonFile('angular.json', (configJson) => { configJson.projects['test-project'].architect.build.options.preserveSymlinks = true; }); @@ -32,10 +28,15 @@ export default async function () { buildReadyRegEx, ); + await setTimeout(200); + // Trigger a rebuild await Promise.all([ waitForAnyProcessOutputToMatch(buildReadyRegEx), appendToFile('src/link-source.ts', `\nconsole.log('foo-bar');`), ]); - await expectFileToMatch('dist/test-project/browser/main.js', `console.log('foo-bar')`); + + await setTimeout(200); + + await expectFileToMatch('dist/test-project/browser/main.js', /console\.log\(["']foo-bar["']\);/); } diff --git a/tests/e2e/tests/vitest/browser-webdriverio.ts b/tests/e2e/tests/vitest/browser-webdriverio.ts index 25a8ccaae5c1..231f5fca4041 100644 --- a/tests/e2e/tests/vitest/browser-webdriverio.ts +++ b/tests/e2e/tests/vitest/browser-webdriverio.ts @@ -5,9 +5,6 @@ import { writeFile } from '../../utils/fs'; import { updateJsonFile } from '../../utils/project'; export default async function (): Promise { - // TODO: investigate why this test hangs in CI but works locally. - return; - await applyVitestBuilder({ webdriver: true, });