fix(@angular/cli): allow command arguments named help

Previously, `localYargs.help('help', ...)` was always enabled regardless of whether `--help` was passed. In Yargs, enabling `.help()` also registers an implicit `help` command/positional trigger, causing commands with a positional argument named `help` (such as `ng generate component help`) to display the CLI help output instead of executing the command.

Only enable Yargs help handling when `--help` is present in the parsed options.

Fixes #25705

Author: alan-agius4

packages/angular/cli/src/command-builder/command-runner.ts

@@ -137,7 +137,7 @@ export async function runCommand(args: string[], logger: logging.Logger): Promis
       hidden: true,
       type: 'boolean',
     })
-    .help('help', 'Shows a help message for this command in the console.')
+    .help(help, help ? 'Shows a help message for this command in the console.' : undefined)
     // A complete list of strings can be found: https://github.com/yargs/yargs/blob/main/locales/en.json
     .updateStrings({
       'Commands:': colors.cyan('Commands:'),

tests/e2e/tests/generate/component/component-basic.ts

@@ -2,19 +2,20 @@ import { join } from 'node:path';
 import { ng } from '../../../utils/process';
 import { expectFileToExist } from '../../../utils/fs';
 
-export default function () {
-  const projectDir = join('src', 'app');
-  const componentDir = join(projectDir, 'test-component');
+export default async function () {
+  const componentDir = 'src/app/test-component';
 
-  return (
-    ng('generate', 'component', 'test-component')
-      .then(() => expectFileToExist(componentDir))
-      .then(() => expectFileToExist(join(componentDir, 'test-component.ts')))
-      .then(() => expectFileToExist(join(componentDir, 'test-component.spec.ts')))
-      .then(() => expectFileToExist(join(componentDir, 'test-component.html')))
-      .then(() => expectFileToExist(join(componentDir, 'test-component.css')))
+  await ng('generate', 'component', 'test-component');
+  await expectFileToExist(componentDir);
+  await expectFileToExist(join(componentDir, 'test-component.ts'));
+  await expectFileToExist(join(componentDir, 'test-component.spec.ts'));
+  await expectFileToExist(join(componentDir, 'test-component.html'));
+  await expectFileToExist(join(componentDir, 'test-component.css'));
 
-      // Try to run the unit tests.
-      .then(() => ng('test', '--watch=false'))
-  );
+  // Try to run the unit tests.
+  await ng('test', '--watch=false');
+
+  // Should generate component that is named "help".
+  await ng('generate', 'component', 'help');
+  await expectFileToExist('src/app/help/help.ts');
 }