Repository navigation
Commit 11eeeb0
committed
ci: enable runfiles when cross-building Windows E2E tests
When cross-building the Windows E2E targets on Linux with
`--platforms=tools:windows_x64`, `@bazel_lib//lib:enable_runfiles`
evaluates to `False` unless `--enable_runfiles` is passed, causing
`aspect_rules_js` to generate the test launcher script with
`JS_BINARY__NO_RUNFILES=1`.
In `aspect_rules_js` 3.5.2, `JS_BINARY__NO_RUNFILES=1` resolves the
entry point using `JS_BINARY__BINDIR` (`bazel-out/k8-fastbuild/bin`)
instead of `BAZEL_BINDIR` (`.`), which fails on Windows CI where the
tests are executed from the built `.runfiles` directory tree. Passing
`--enable_runfiles` during the Windows E2E cross-build ensures the
launcher script resolves the entry point from the runfiles directory.1 parent 47bc9c3 commit 11eeeb0
2 files changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | | - | |
| 121 | + | |
| 122 | + | |
122 | 123 | | |
123 | 124 | | |
124 | 125 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | | - | |
| 146 | + | |
| 147 | + | |
147 | 148 | | |
148 | 149 | | |
149 | 150 | | |
| |||
0 commit comments