Mac RadioButton spacing

[mischnic]

libui/darwin/radiobuttons.m

Line 10 in 6d8150d

// LONGTERM 6 units of spacing between buttons, as suggested by Interface Builder?

How long is longterm?

The right looks way better:

[andlabs]

I forget why I made that LONGTERM, but I think it's because that one on the right looks like less than 6 units...

[mischnic]

diff --git a/darwin/radiobuttons.m b/darwin/radiobuttons.m
index 25d773c9..0d379aca 100644
--- a/darwin/radiobuttons.m
+++ b/darwin/radiobuttons.m
@@ -123,14 +123,14 @@ void uiRadioButtonsAppend(uiRadioButtons *r, const char *text)
 		constraint = mkConstraint(b, NSLayoutAttributeTop,
 			NSLayoutRelationEqual,
 			r->view, NSLayoutAttributeTop,
-			1, 0,
+			1, 4,
 			@"uiRadioButtons first button top constraint");
 	else {
 		b2 = buttonAt(r, [r->buttons count] - 2);
 		constraint = mkConstraint(b, NSLayoutAttributeTop,
 			NSLayoutRelationEqual,
 			b2, NSLayoutAttributeBottom,
-			1, 0,
+			1, 4,
 			@"uiRadioButtons non-first button top constraint");
 	}
 	[r->view addConstraint:constraint];

With 4 (as in diff):

5:

6:

I would say 4 or 5 looks better. But more importantly, the circles aren't overlaying anymore (so this is a better default if the spacing can't be changed).

(The window on the right has 5 and then 6 pixels space in between.)

[mischnic]

The reason for

libui/darwin/radiobuttons.m

Line 4 in 6d8150d

// TODO resizing the controlgallery vertically causes the third button to still resize :|

is that the container of the radio buttons is getting resized on window resizing as if stretchy was set to true (but isn't).

Before resizing (individual buttons and container colored in):

After resizing: (container grew with the window and because the bottom of the last button is glued to the container through a constraint it grows as well)

Should this be happening with

libui/examples/controlgallery/main.c

Line 156 in 86c4485

uiBoxAppend(vbox, uiControl(rb), 0);

(stretchy = 0)?

---

How should the radio buttons behave when they are indeed set to be stretchy? Grow the container and don't change button spacing? Or keep the spacing even and grow it proportionally (might look odd)?

[andlabs]

For the last question, IIRC the correct behavior is the latter (buttons are top-aligned always).

libui's Auto Layout is still wonky. One day I'll figure out how to do everything Correctly...