Skip to content

Commit 272196a

Browse files
authored
Move version-conditional uvloop install to requirements-dev.txt
PR #337 by @TimothyFitz
2 parents 67b01a8 + dece1d0 commit 272196a

3 files changed

Lines changed: 1 addition & 7 deletions

File tree

.travis.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ before_script:
3434
- "mysql -e 'DROP DATABASE IF EXISTS test_pymysql2; create database test_pymysql2 DEFAULT CHARACTER SET utf8 DEFAULT COLLATE utf8_general_ci;'"
3535

3636
install:
37-
- if python -c "import sys; sys.exit(sys.version_info < (3,5))"; then
38-
pip install uvloop;
39-
fi
4037
- pip install -Ur requirements-dev.txt
4138
- pip install .
4239
- pip install codecov

CONTRIBUTING.rst

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,6 @@ After that please install libraries required for development::
7373

7474
$ pip install -r requirements-dev.txt
7575

76-
We also recommend to install *ipdb* but it's on your own::
77-
78-
$ pip install ipdb
79-
8076
Congratulations, you are ready to run the test suite
8177

8278
Install database

requirements-dev.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@ docker==3.4.1
1010
sphinx==1.7.6
1111
sphinxcontrib-asyncio==0.2.0
1212
sqlalchemy==1.2.10
13+
uvloop==0.11.2; python_version >= '3.5'

0 commit comments

Comments
 (0)