Validate Content-Length format in ClientRequest

Author: jmestwa-coder

aiohttp/client_reqrep.py

@@ -755,7 +755,13 @@ def _get_content_length(self) -> int | None:
 
         content_length_hdr = self.headers[hdrs.CONTENT_LENGTH]
         if not _DIGITS_RE.fullmatch(content_length_hdr):
+<<<<<<< HEAD
             raise ValueError(f"Invalid Content-Length header: {content_length_hdr!r}")
+=======
+            raise ValueError(
+                f"Invalid Content-Length header: {content_length_hdr!r}"
+            )
+>>>>>>> c59955e89 (Validate Content-Length format in ClientRequest)
         return int(content_length_hdr)
 
     @property

tests/test_web_functional.py

@@ -196,6 +196,29 @@ async def handler(request: web.Request) -> web.Response:
     resp.release()
 
 
+async def test_content_length_invalid(
+    aiohttp_client: AiohttpClient,
+) -> None:
+    async def handler(request: web.Request) -> web.Response:
+        body = await request.read()
+        return web.Response(body=body)
+
+    app = web.Application()
+    app.router.add_post("/", handler)
+    client = await aiohttp_client(app)
+
+    resp = await client.post("/", data=b"hello world", headers={CONTENT_LENGTH: "11"})
+    assert resp.status == 200
+    assert await resp.read() == b"hello world"
+    resp.release()
+
+    with pytest.raises(ValueError, match="Invalid Content-Length header"):
+        await client.post("/", data=b"hello world", headers={CONTENT_LENGTH: "-100"})
+
+    with pytest.raises(ValueError, match="Invalid Content-Length header"):
+        await client.post("/", data=b"hello world", headers={CONTENT_LENGTH: " 100"})
+
+
 @pytest.mark.skipif(sys.version_info < (3, 11), reason="Needs Task.cancelling()")
 async def test_cancel_shutdown(aiohttp_client: AiohttpClient) -> None:
     async def handler(request: web.Request) -> web.Response: