From 1eba14b6cdbe8c874fc9448008ba3d37318ea3f2 Mon Sep 17 00:00:00 2001 From: Mior Muhammad Zaki Date: Tue, 10 Nov 2026 10:19:23 +0800 Subject: [PATCH] Remove return statement in PubSubHttpClient constructor In PHP class constructor should return `void` as per manual https://www.php.net/manual/en/language.oop5.decon.php and using `return $this;` will start to output warning in PHP 8.6 ``` 1) /home/runner/work/framework/framework/vendor/ably/pubsub-server/src/PubSubHttpClient.php:110 Returning a value from a constructor is deprecated Triggered by: * Illuminate\Tests\Broadcasting\Ably2BroadcasterTest::testAuthCallValidAuthenticationResponseWithPrivateChannelWhenCallbackReturnTrue /home/runner/work/framework/framework/tests/Broadcasting/Ably2BroadcasterTest.php:32 ``` --- src/PubSubHttpClient.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/PubSubHttpClient.php b/src/PubSubHttpClient.php index b03330c..10fb9eb 100644 --- a/src/PubSubHttpClient.php +++ b/src/PubSubHttpClient.php @@ -107,7 +107,6 @@ public function __construct( $options = [] ) { $this->channels = new Channels( $this ); $this->push = new Push( $this ); $this->host = new Host($this->options); - return $this; } /**