From 7d43f1ddd1242853e3a3abad31a779ca6dd83647 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Tue, 28 Jul 2026 06:00:45 +0200 Subject: [PATCH] GH Actions: fix flagnames in "Coveralls finish" workflow The flag names in the `carryforward` key in the `finish-coveralls.yml` workflow were out of date and incomplete. Let's see if the changes in this commit improve things. I've also added a comment now to alert GH Action maintainers to update the flags in the `finish-coveralls.yml` workflow when they update test matrices. Hopefully this will help going forward. --- .github/workflows/finish-coveralls.yml | 2 +- .github/workflows/jstest.yml | 4 ++++ .github/workflows/test.yml | 4 ++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/finish-coveralls.yml b/.github/workflows/finish-coveralls.yml index 99d385a4a91..0ca6a1f744b 100644 --- a/.github/workflows/finish-coveralls.yml +++ b/.github/workflows/finish-coveralls.yml @@ -105,5 +105,5 @@ jobs: COVERALLS_SERVICE_NUMBER: ${{ github.sha }} # Connect all builds together. with: github-token: ${{ secrets.GITHUB_TOKEN }} - carryforward: "unit-php-7.4,unit-php-8.3,php-7.4-wp-6.8-ms,php-8.3-wp-latest,php-8.3-wp-latest-ms,package-analysis-report,package-browserslist-config,package-components,package-feature-flag,package-helpers,package-js,package-replacement-variable-editor,package-search-metadata-previews,package-social-metadata-forms,package-social-metadata-previews,package-yoastseo" + carryforward: "unit-php-7.4,unit-php-8.3,php-7.4-wp-6.8,php-7.4-wp-6.8-ms,php-8.3-wp-latest,php-8.3-wp-latest-ms,package-analysis-report,package-browserslist-config,package-components,package-dashboard-frontend,package-feature-flag,package-helpers,package-js,package-replacement-variable-editor,package-search-metadata-previews,package-social-metadata-forms,package-social-metadata-previews,package-ui-library,package-yoastseo" parallel-finished: true diff --git a/.github/workflows/jstest.yml b/.github/workflows/jstest.yml index e087050657d..547a1094a3e 100644 --- a/.github/workflows/jstest.yml +++ b/.github/workflows/jstest.yml @@ -60,6 +60,8 @@ jobs: # As these packages are all unique, don't stop the workflow when the test run of one package fails. fail-fast: false matrix: + # IMPORTANT: when these are updated, make sure to also update the `carryforward` flag names + # in the `finish-coveralls.yml` workflow! package: - 'analysis-report' - 'browserslist-config' @@ -141,6 +143,8 @@ jobs: # As these packages are all unique, don't stop the workflow when the test run of one package fails. fail-fast: false matrix: + # IMPORTANT: when these are updated, make sure to also update the `carryforward` flag names + # in the `finish-coveralls.yml` workflow! include: - package: 'yoastseo' needs_premium_config: true diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 991c03c9ddb..1ddc486a845 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -51,6 +51,8 @@ jobs: coverage: [false] # Run code coverage only on high/low PHP. + # IMPORTANT: when these are updated, make sure to also update the `carryforward` flag names + # in the `finish-coveralls.yml` workflow! include: - php_version: 7.4 coverage: true @@ -141,6 +143,8 @@ jobs: strategy: matrix: + # IMPORTANT: when these are updated, make sure to also update the `carryforward` flag names + # in the `finish-coveralls.yml` workflow! include: - php_version: "7.4" wp_version: "6.8"