From 224f886bb7fe9c081adc24cfaa952d652fa0d2d9 Mon Sep 17 00:00:00 2001 From: kazi mohammad Foysal <95936171+kmfoysal06@users.noreply.github.com> Date: Sun, 26 Jul 2026 21:37:22 +0600 Subject: [PATCH 1/4] fix: Plugin "Check it!" button fails silently with nonce error #893 --- assets/js/plugin-check-admin.js | 7 +++++++ includes/Admin/Admin_Page.php | 4 ++++ templates/admin-page.php | 1 + 3 files changed, 12 insertions(+) diff --git a/assets/js/plugin-check-admin.js b/assets/js/plugin-check-admin.js index 22227cc4e..95b59b5e4 100644 --- a/assets/js/plugin-check-admin.js +++ b/assets/js/plugin-check-admin.js @@ -5,6 +5,7 @@ 'plugin-check__export-controls' ); const spinner = document.getElementById( 'plugin-check__spinner' ); + const clientError = document.getElementById( 'plugin-check__client-error' ); const pluginsList = document.getElementById( 'plugin-check__plugins-dropdown' ); @@ -21,6 +22,7 @@ ! resultsContainer || ! exportContainer || ! spinner || + ! clientError || ! categoriesList.length || ! typesList.length ) { @@ -83,6 +85,9 @@ checkItButton.disabled = true; pluginsList.disabled = true; spinner.classList.add( 'is-active' ); + clientError.innerText = ''; + clientError.classList.add("is-hidden"); + for ( let i = 0; i < categoriesList.length; i++ ) { categoriesList[ i ].disabled = true; } @@ -106,6 +111,8 @@ resetForm(); } ) .catch( ( error ) => { + clientError.innerText = error.message; + clientError.classList.remove("is-hidden"); console.error( error ); resetForm(); diff --git a/includes/Admin/Admin_Page.php b/includes/Admin/Admin_Page.php index 5dd4881e8..ff8826b22 100644 --- a/includes/Admin/Admin_Page.php +++ b/includes/Admin/Admin_Page.php @@ -434,6 +434,10 @@ public function admin_footer() { .plugin-check__export-controls.is-hidden { display: none; } + /** Plugin Check Client Errors **/ + #plugin-check__client-error.is-hidden { + display: none; + } " id="plugin-check__submit" class="button button-primary" /> +

From de72cbc3f5b2d09f6a2f4c554d0ffbf720ebf488 Mon Sep 17 00:00:00 2001 From: kazi mohammad Foysal <95936171+kmfoysal06@users.noreply.github.com> Date: Sun, 26 Jul 2026 16:22:13 +0000 Subject: [PATCH 2/4] fix lint errors --- assets/js/plugin-check-admin.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assets/js/plugin-check-admin.js b/assets/js/plugin-check-admin.js index 95b59b5e4..e63ab218e 100644 --- a/assets/js/plugin-check-admin.js +++ b/assets/js/plugin-check-admin.js @@ -86,7 +86,7 @@ pluginsList.disabled = true; spinner.classList.add( 'is-active' ); clientError.innerText = ''; - clientError.classList.add("is-hidden"); + clientError.classList.add( 'is-hidden' ); for ( let i = 0; i < categoriesList.length; i++ ) { categoriesList[ i ].disabled = true; @@ -112,7 +112,7 @@ } ) .catch( ( error ) => { clientError.innerText = error.message; - clientError.classList.remove("is-hidden"); + clientError.classList.remove( 'is-hidden' ); console.error( error ); resetForm(); From 5bb4fdb574d718bf11141a33a8c1d2864e57b74c Mon Sep 17 00:00:00 2001 From: kmfoysal06 Date: Tue, 4 Aug 2026 10:24:22 +0600 Subject: [PATCH 3/4] fix: enhance client error handling and accessibility in admin page --- assets/js/plugin-check-admin.js | 2 ++ templates/admin-page.php | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/assets/js/plugin-check-admin.js b/assets/js/plugin-check-admin.js index e63ab218e..f1270d112 100644 --- a/assets/js/plugin-check-admin.js +++ b/assets/js/plugin-check-admin.js @@ -113,6 +113,8 @@ .catch( ( error ) => { clientError.innerText = error.message; clientError.classList.remove( 'is-hidden' ); + clientError.focus(); + console.error( error ); resetForm(); diff --git a/templates/admin-page.php b/templates/admin-page.php index 8fca7e929..b45a2a1c2 100644 --- a/templates/admin-page.php +++ b/templates/admin-page.php @@ -39,7 +39,7 @@ - +

From 0c31eb8faabf4868fe130fc52534073bec82fec2 Mon Sep 17 00:00:00 2001 From: kmfoysal06 Date: Tue, 4 Aug 2026 10:26:56 +0600 Subject: [PATCH 4/4] fix: correct formatting in error handling for client error display --- assets/js/plugin-check-admin.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/js/plugin-check-admin.js b/assets/js/plugin-check-admin.js index f1270d112..f35c0cd16 100644 --- a/assets/js/plugin-check-admin.js +++ b/assets/js/plugin-check-admin.js @@ -114,7 +114,7 @@ clientError.innerText = error.message; clientError.classList.remove( 'is-hidden' ); clientError.focus(); - + console.error( error ); resetForm();