wasm-emscripten-finalize: Add mainReadsParams metadata (#2247)

The new flag indicates whether main reads the argc/argv parameters. If it does not, we can avoid emitting code to generate those arguments in the JS, which is not trivial in small programs - it requires some string conversion code.

Nicely the existing test inputs were enough for testing this (see outputs).

This depends on an emscripten change to land first, as emscripten.py asserts on metadata fields it doesn't recognize.

Author: kripken

src/wasm/wasm-emscripten.cpp

@@ -1042,7 +1042,23 @@ std::string EmscriptenGlueGenerator::generateEmscriptenMetadata(
   wasm.features.iterFeatures([&](FeatureSet::Feature f) {
     meta << nextElement() << "\"--enable-" << FeatureSet::toString(f) << '"';
   });
-  meta << "\n  ]\n";
+  meta << "\n  ],\n";
+
+  auto mainReadsParams = false;
+  if (auto* exp = wasm.getExportOrNull("main")) {
+    if (exp->kind == ExternalKind::Function) {
+      auto* main = wasm.getFunction(exp->value);
+      mainReadsParams = true;
+      // If main does not read its parameters, it will just be a stub that
+      // calls __original_main (which has no parameters).
+      if (auto* call = main->body->dynCast<Call>()) {
+        if (call->operands.empty()) {
+          mainReadsParams = false;
+        }
+      }
+    }
+  }
+  meta << "  \"mainReadsParams\": " << int(mainReadsParams) << '\n';
 
   meta << "}\n";
 

test/lld/duplicate_imports.wast.out

@@ -115,7 +115,8 @@
     "invoke_ffd"
   ],
   "features": [
-  ]
+  ],
+  "mainReadsParams": 1
 }
 -- END METADATA --
 ;)

test/lld/em_asm.wast.mem.out

@@ -262,7 +262,8 @@
   "invokeFuncs": [
   ],
   "features": [
-  ]
+  ],
+  "mainReadsParams": 0
 }
 -- END METADATA --
 ;)

test/lld/em_asm.wast.out

@@ -263,7 +263,8 @@
   "invokeFuncs": [
   ],
   "features": [
-  ]
+  ],
+  "mainReadsParams": 0
 }
 -- END METADATA --
 ;)

test/lld/em_asm_O0.wast.out

@@ -123,7 +123,8 @@
   "invokeFuncs": [
   ],
   "features": [
-  ]
+  ],
+  "mainReadsParams": 1
 }
 -- END METADATA --
 ;)

test/lld/em_asm_shared.wast.out

@@ -244,7 +244,8 @@
   "invokeFuncs": [
   ],
   "features": [
-  ]
+  ],
+  "mainReadsParams": 0
 }
 -- END METADATA --
 ;)

test/lld/em_asm_table.wast.out

@@ -93,7 +93,8 @@
   "invokeFuncs": [
   ],
   "features": [
-  ]
+  ],
+  "mainReadsParams": 0
 }
 -- END METADATA --
 ;)

test/lld/em_js_O0.wast.out

@@ -73,7 +73,8 @@
   "invokeFuncs": [
   ],
   "features": [
-  ]
+  ],
+  "mainReadsParams": 0
 }
 -- END METADATA --
 ;)

test/lld/hello_world.passive.wast.out

@@ -105,7 +105,8 @@
   "invokeFuncs": [
   ],
   "features": [
-  ]
+  ],
+  "mainReadsParams": 0
 }
 -- END METADATA --
 ;)

test/lld/hello_world.wast.mem.out

@@ -97,7 +97,8 @@
   "invokeFuncs": [
   ],
   "features": [
-  ]
+  ],
+  "mainReadsParams": 0
 }
 -- END METADATA --
 ;)