Skip to content

Commit d3ca4a0

Browse files
authored
[Fuzzing] Do not clusterfuzz multibyte (#8488)
ClusterFuzz fuzzer in fuzz_opt.py hit this. Also add fp16 in fuzz_opt.py for overall consistency, but fp16 is disabled more generally there as well, a few lines above anyhow.
1 parent 899e44e commit d3ca4a0

2 files changed

Lines changed: 16 additions & 5 deletions

File tree

scripts/bundle_clusterfuzz.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,14 +102,16 @@
102102
binaryen_lib = shared.options.binaryen_lib
103103

104104
# ClusterFuzz's run.py uses these features. Keep this in sync with that, so that
105-
# we only bundle initial content that makes sense for it.
105+
# we only bundle initial content that makes sense for it. Also keep it in sync
106+
# with fuzz_opt.py's DISALLOWED_FEATURES_IN_V8.
106107
features = [
107108
'-all',
108109
'--disable-shared-everything',
109110
'--disable-fp16',
110111
'--disable-strings',
111112
'--disable-stack-switching',
112113
'--disable-relaxed-atomics',
114+
'--disable-multibyte',
113115
]
114116

115117
with tarfile.open(output_file, "w:gz") as tar:

scripts/fuzz_opt.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,19 @@
6262

6363
CLOSED_WORLD_FLAG = '--closed-world'
6464

65-
# V8 does not support shared memories when running with
66-
# shared-everything enabled, so do not fuzz shared-everything
67-
# for now. The remaining features are not yet implemented in v8.
68-
DISALLOWED_FEATURES_IN_V8 = ['shared-everything', 'strings', 'stack-switching', 'relaxed-atomics', 'multibyte']
65+
# V8 does not support shared memories when running with shared-everything
66+
# enabled, so do not fuzz shared-everything for now. The remaining features are
67+
# not yet implemented in v8.
68+
#
69+
# Keep this in sync with bundle_clusterfuzz.py.
70+
DISALLOWED_FEATURES_IN_V8 = [
71+
'shared-everything',
72+
'fp16',
73+
'strings',
74+
'stack-switching',
75+
'relaxed-atomics',
76+
'multibyte',
77+
]
6978

7079

7180
# utilities

0 commit comments

Comments
 (0)