wasm-emscripten-finalize: Add more checking of __data_end global (#2352)

sbc100 · web-flow · commit bf7e40f9bb33 · 2019-09-23T17:06:01.000-07:00
diff --git a/src/tools/wasm-emscripten-finalize.cpp b/src/tools/wasm-emscripten-finalize.cpp
@@ -197,6 +197,9 @@ int main(int argc, const char* argv[]) {
     if (dataEnd->type != Type::i32) {
       Fatal() << "__data_end global has wrong type";
     }
+    if (dataEnd->imported()) {
+      Fatal() << "__data_end must not be an imported global";
+    }
     Const* dataEndConst = dataEnd->init->cast<Const>();
     dataSize = dataEndConst->value.geti32() - globalBase;
   }

Original file line number	Diff line number	Diff line change
`@@ -197,6 +197,9 @@ int main(int argc, const char* argv[]) {`
`197`	`197`	`if (dataEnd->type != Type::i32) {`
`198`	`198`	`Fatal() << "__data_end global has wrong type";`
`199`	`199`	`}`
	`200`	`+ if (dataEnd->imported()) {`
	`201`	`+ Fatal() << "__data_end must not be an imported global";`
	`202`	`+ }`
`200`	`203`	`Const* dataEndConst = dataEnd->init->cast<Const>();`
`201`	`204`	`dataSize = dataEndConst->value.geti32() - globalBase;`
`202`	`205`	`}`