Skip to content

Commit 8d19d00

Browse files
alexcrichtondschuff
authored andcommitted
Upgrade the build container for linux releases (#2405)
This is a continued effort to try and track down #2273 which came up again and is still present in the current release binaries. Issues like crystal-lang/crystal#4276 may indicate that C++ exceptions are just somewhat broken with static linking when using alpine, but I've at least locally been able to verify that upgrading the container produces working binaries which previously segfaulted on some wasm files.
1 parent bb41564 commit 8d19d00

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ jobs:
4949
before_install:
5050
- export ASAN_OPTIONS="symbolize=1"
5151
install:
52-
- nvm install 10
53-
- nvm use 10
52+
- nvm install 12
53+
- nvm use 12
5454
- pip3 install --user flake8==3.7.8
5555
# get jsvu in order to get more js engines
5656
- npm install jsvu -g
@@ -121,7 +121,7 @@ jobs:
121121
compiler: gcc
122122
env: ARCH=x86_64
123123
before_install:
124-
- docker run -w /src -dit --name alpine -v $(pwd):/src node:10-alpine
124+
- docker run -w /src -dit --name alpine -v $(pwd):/src node:13-alpine
125125
- alpine() { docker exec -it alpine "$@"; }
126126
install:
127127
- alpine apk update

scripts/test/node-esm-loader.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@ export function resolve(specifier, parentModuleURL = baseURL, defaultResolve) {
2323
const resolved = new URL('./scripts/test/' + specifier + '.js', baseURL);
2424
return {
2525
url: resolved.href,
26-
format: 'esm'
26+
format: 'module'
2727
};
2828
}
2929

3030
const resolved = new URL(specifier, parentModuleURL);
3131
return {
3232
url: resolved.href,
33-
format: 'esm'
33+
format: 'module'
3434
};
3535
}

scripts/test/wasm2js.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def test_wasm2js_output():
9494
fail_if_not_identical(out, '')
9595
cmd = node[:]
9696
cmd.append('a.2asm.asserts.mjs')
97-
out = run_command(cmd, expected_err='', err_ignore='The ESM module loader is experimental')
97+
out = run_command(cmd, expected_err='', err_ignore='ExperimentalWarning')
9898
fail_if_not_identical(out, '')
9999

100100
fail_if_not_identical_to_file(''.join(all_out), expected_file)

0 commit comments

Comments
 (0)