Skip to content

Commit 6ca3f4c

Browse files
authored
Enable all features in wasm-shell assert failure tests (#2254)
If we don't enable features in assertion failure tests, new feature tests fail not because they are malformed but because they have unsupported features. It's hard to add tests because existing `assert_invalid` tests were already failing because they have unsupported features.
1 parent 443c006 commit 6ca3f4c

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

src/tools/wasm-shell.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ static void run_asserts(Name moduleName,
142142
id == ASSERT_UNLINKABLE) {
143143
// a module invalidity test
144144
Module wasm;
145+
wasm.features = FeatureSet::All;
145146
bool invalid = false;
146147
std::unique_ptr<SExpressionWasmBuilder> builder;
147148
try {

0 commit comments

Comments
 (0)