Skip to content

Commit 32b7a25

Browse files
authored
[NFC] Remove no longer needed v8 flag to avoid warnings (#7297)
Recent v8 prints "warning: unrecognized flag" about it. This warning broke a test. Add some logging to the test as well, to make it easier to debug in the future.
1 parent 19dd23d commit 32b7a25

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

scripts/fuzz_opt.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1718,7 +1718,10 @@ def handle(self, wasm):
17181718
# Make sure that fuzz_shell.js actually executed all exports from both
17191719
# wasm files.
17201720
exports = get_exports(wasm, ['func']) + get_exports(second_wasm, ['func'])
1721-
assert output.count(FUZZ_EXEC_CALL_PREFIX) == len(exports)
1721+
calls_in_output = output.count(FUZZ_EXEC_CALL_PREFIX)
1722+
if calls_in_output == 0:
1723+
print(f'warning: no calls in output. output:\n{output}')
1724+
assert calls_in_output == len(exports)
17221725

17231726
output = fix_output(output)
17241727

scripts/test/shared.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,6 @@ def has_shell_timeout():
255255
V8_OPTS = [
256256
'--wasm-staging',
257257
'--experimental-wasm-compilation-hints',
258-
'--experimental-wasm-memory64',
259258
'--experimental-wasm-stringref',
260259
'--experimental-wasm-fp16',
261260
]

0 commit comments

Comments
 (0)