Skip to content

Commit cc2a889

Browse files
AustinShalitJLLeitschuh
authored andcommitted
Update gradle and add jfx plugin (#637)
* Update gradle and add jfx plugin * Update CI configs * Update travis-ci scripts for new build directory
1 parent d6a3bbe commit cc2a889

13 files changed

Lines changed: 52 additions & 58 deletions

File tree

.travis-scripts/before-deploy.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
2-
ls -R ui/build/distributions | awk '
2+
ls -R ui/build/jfx/native | awk '
33
/:$/&&f{s=$0;f=0}
44
/:$/&&!f{sub(/:$/,"");s=$0;f=1;next}
55
NF&&f{ print s"/"$0 }'

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ before_install:
2727

2828
# Only do an assemble when we aren't building a pull request
2929
install:
30-
- '[ "${TRAVIS_PULL_REQUEST}" = "false" ] && ./gradlew :ui:assemble --stacktrace || ./gradlew --stacktrace '
30+
- '[ "${TRAVIS_PULL_REQUEST}" = "false" ] && ./gradlew :ui:jfxNative --stacktrace || ./gradlew --stacktrace '
3131

3232
script:
3333
- ./gradlew checkstyleMain checkstyleTest pmdMain jacocoTestReport jacocoRootReport test --stacktrace -Pheadless=true -PlogTests
@@ -56,7 +56,7 @@ deploy:
5656
api_key:
5757
secure: bdjiFXG3VBcM1iyxeputsWA9vHxgLNcxRB1i0REDNAnIEvDWpAdVr1jPBejeiOEw9s+k6EItATvQ2I7Xp5iKnYaXn0NuHzM3OSY8WNVCc+gBTaQwkijPBqi/vEXaO502CscW+H2U26QZGS/jJiUuieeErtzCNcWmCv8SRc5NFOVYdSlhAmp+aPeu2YwuweiMZNVquYM2hx7murghOYSF5hQTKq4/zrziENVi78XZS8rJFmxwOGqNj1GBLul2F9poIPjzDbPVJLeXTJEY+N3aYGJ4GyZYf6p8ynDO/v043/GuOAyNfkgSwhCcTQlmLG/mm6P9CUMoDQR9klh2eDswgrIP4rGLwILg3035nqHqwgTIKVXfspni3P/65siS6lXV0M5flEkRysMBr1GQhaIEUM32ArreMzAtC2Vn2CviKG0TwLmxyd/7W3JdoX4KrHAcKBwbqFDImWw43S6N63oTUEw6GjrI+CndwgF9RNgr5SAyS28LFXViOJe7JlGVUNU33kMNpEJxzVREzkJsO8aicaZTrvDniFOfg2WhrAyhjxmh4/IOHDE6qgtxw+2+TUzMlwdzdxb90BeXg2XfMichmKfQYQFEmZntCZcoHHDG5jbCTyAvFuOv6tdPjpr69QjiEJhEbohw8CEwoGhy1kxxQcCDCfABrOTivJ39Ui8MC6k=
5858
file_glob: true
59-
file: "ui/build/distributions/*.{deb,pkg,dmg}"
59+
file: "ui/build/jfx/native/*.{deb,pkg,dmg}"
6060
skip_cleanup: true
6161
on:
6262
repo: WPIRoboticsProjects/GRIP

appveyor.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ install:
22
- choco install -y InnoSetup
33

44
build_script:
5-
- gradlew.bat :ui:assemble --stacktrace
5+
- gradlew.bat :ui:jfxNative --stacktrace
66

77
# to run your custom scripts instead of automatic tests
88
test_script:
@@ -12,7 +12,7 @@ platform:
1212
- x64
1313

1414
artifacts:
15-
- path: ui\build\distributions\*.exe
15+
- path: ui\build\jfx\native\*.exe
1616

1717

1818
deploy:

build.gradle

Lines changed: 17 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ buildscript {
77
}
88

99
dependencies {
10+
classpath group: 'de.dynamicfiles.projects.gradle.plugins', name: 'javafx-gradle-plugin', version: '8.5.1'
1011
classpath 'com.netflix.nebula:gradle-aggregate-javadocs-plugin:2.2.+'
1112
classpath 'net.ltgt.gradle:gradle-errorprone-plugin:0.0.8'
1213
}
@@ -318,7 +319,7 @@ project(":ui") {
318319
apply plugin: 'idea'
319320
apply plugin: 'jacoco'
320321
apply plugin: 'application'
321-
apply from: 'http://dl.bintray.com/shemnon/javafx-gradle/8.1.1/javafx.plugin'
322+
apply plugin: 'javafx-gradle-plugin'
322323

323324
configurations {
324325
ideProvider
@@ -356,20 +357,16 @@ project(":ui") {
356357
}
357358

358359

359-
javafx {
360-
profiles {
361-
linux {
362-
category = 'Development'
363-
bundleArguments = [
364-
// for DEB bundles
365-
'email': 'wpilib@wpi.edu', // This is the email used for the deb maintainer field.
366-
]
367-
}
368-
}
369-
appID = 'GRIP'
370-
appName = 'GRIP'
360+
jfx {
371361
mainClass = "edu.wpi.grip.ui.Main"
372-
version = getVersionSimple()
362+
preLoader = "edu.wpi.grip.preloader.GripPreloader"
363+
364+
identifier = "GRIP"
365+
appName = "GRIP"
366+
vendor = "Worcester Polytechnic Institute"
367+
nativeReleaseVersion = "${getVersionSimple()}-${arch}"
368+
369+
jfxMainAppJarName = "${jfx.appName}-${jfx.nativeReleaseVersion}.jar"
373370

374371
// This prevents the JIT from eating stack traces that get thrown a lot
375372
// This is slower but means we actually get the stack traces instead of
@@ -378,19 +375,12 @@ project(":ui") {
378375
// See: https://plumbr.eu/blog/java/on-a-quest-for-missing-stacktraces
379376
jvmArgs = ["-XX:-OmitStackTraceInFastThrow"]
380377

381-
systemProperties = ['javafx.preloader':'edu.wpi.grip.preloader.GripPreloader']
382-
}
383-
mainClassName = javafx.mainClass
384-
385-
// The JavaFX plugin does not provide a way to change the installer artifact's name without changing the appName or appID,
386-
// so instead, we simply rename the artifact to append the architecture (x86 or x64)
387-
jfxDeploy.doLast {
388-
def filet = fileTree(dir: 'build/distributions', include: "${javafx.appName}-${getVersionSimple()}.*")
389-
filet.each { File f ->
390-
def f2 = new File(f.getParentFile(), "${f.getName().replace("${getVersionSimple()}", "${getVersionSimple()}-${arch}")}")
391-
f.renameTo(f2)
392-
}
378+
// This was a workaround introduced by the plugin dev. For some reason the build fails
379+
// when the workaround is enabled in Java 1.8.0_101. If you are building with a version
380+
// less than _101 you may need to set this to false.
381+
skipNativeLauncherWorkaround124 = true
393382
}
383+
mainClassName = jfx.mainClass
394384
}
395385

396386
/*
@@ -417,5 +407,5 @@ task jacocoRootReport(type: JacocoReport, group: 'Coverage reports') {
417407
}
418408

419409
task wrapper(type: Wrapper) {
420-
gradleVersion = '2.13'
410+
gradleVersion = '2.14.1'
421411
}

gradle/wrapper/gradle-wrapper.jar

-320 Bytes
Binary file not shown.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Thu May 12 15:14:42 EDT 2016
1+
#Sun Jul 24 01:01:23 PDT 2016
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-2.13-bin.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-2.14.1-bin.zip

gradlew

Lines changed: 25 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gradlew.bat

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ui/src/deploy/package/setup.png

-3.13 KB
Binary file not shown.

ui/src/deploy/package/shortcut.png

-3.13 KB
Binary file not shown.

0 commit comments

Comments
 (0)