Merge pull request #475 from JLLeitschuh/core/sanityTests

Adds Sanity Tests to Most Core Packages

Author: JLLeitschuh

core/src/main/java/edu/wpi/grip/core/OutputSocket.java

@@ -6,6 +6,7 @@
 import com.thoughtworks.xstream.annotations.XStreamAlias;
 import edu.wpi.grip.core.events.SocketPreviewChangedEvent;
 
+import javax.annotation.Nullable;
 import java.util.NoSuchElementException;
 import java.util.Optional;
 
@@ -37,7 +38,7 @@ public void setValueOptional(Optional<? extends T> optionalValue) {
     }
 
     @Override
-    public void setValue(T value) {
+    public void setValue(@Nullable T value) {
         super.setValue(value);
     }
 

core/src/main/java/edu/wpi/grip/core/Palette.java

@@ -11,6 +11,8 @@
 import java.util.Map;
 import java.util.Optional;
 
+import static com.google.common.base.Preconditions.checkNotNull;
+
 /**
  * The palette is a library of operations that can be added as steps in the {@link Pipeline}
  */
@@ -43,6 +45,6 @@ public Collection<Operation> getOperations() {
      * @return The operation with the specified unique name
      */
     public Optional<Operation> getOperationByName(String name) {
-        return Optional.ofNullable(this.operations.get(name));
+        return Optional.ofNullable(this.operations.get(checkNotNull(name, "name cannot be null")));
     }
 }

core/src/main/java/edu/wpi/grip/core/PipelineRunner.java

@@ -15,6 +15,7 @@
 import edu.wpi.grip.core.util.service.AutoRestartingService;
 import edu.wpi.grip.core.util.service.RestartableService;
 
+import javax.annotation.Nullable;
 import javax.inject.Inject;
 import java.util.concurrent.Executor;
 import java.util.concurrent.Semaphore;
@@ -206,7 +207,7 @@ public void onRunPipeline(RunPipelineEvent event) {
     }
 
     @Subscribe
-    public void onStopPipeline(StopPipelineEvent event) {
+    public void onStopPipeline(@Nullable StopPipelineEvent event) {
         stopAsync();
     }
 

core/src/main/java/edu/wpi/grip/core/Socket.java

@@ -3,18 +3,16 @@
 import com.google.common.base.MoreObjects;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.eventbus.EventBus;
-import com.google.common.eventbus.Subscribe;
-import edu.wpi.grip.core.events.ConnectionAddedEvent;
-import edu.wpi.grip.core.events.ConnectionRemovedEvent;
 import edu.wpi.grip.core.events.SocketChangedEvent;
 import edu.wpi.grip.core.events.SocketConnectedChangedEvent;
 
+import javax.annotation.Nullable;
 import java.util.HashSet;
 import java.util.Optional;
 import java.util.Set;
 
-import static com.google.common.base.Preconditions.checkState;
 import static com.google.common.base.Preconditions.checkNotNull;
+import static com.google.common.base.Preconditions.checkState;
 
 /**
  * A Socket is an abstract wrapper for a value that can be updated and passed around operations.  Sockets contain a set of hints
@@ -75,7 +73,7 @@ public synchronized void setValueOptional(Optional<? extends T> optionalValue) {
      *
      * @param value The value to store in this socket. Nullable.
      */
-    public void setValue(T value) {
+    public void setValue(@Nullable T value) {
         setValueOptional(Optional.ofNullable(this.getSocketHint().getType().cast(value)));
 
     }

core/src/main/java/edu/wpi/grip/core/SocketHint.java

@@ -2,6 +2,7 @@
 
 import com.google.common.base.MoreObjects;
 
+import javax.annotation.Nullable;
 import java.util.Arrays;
 import java.util.List;
 import java.util.NoSuchElementException;
@@ -112,7 +113,7 @@ public Builder<T> initialValueSupplier(Supplier<T> initialValueSupplier) {
             return this;
         }
 
-        public Builder<T> initialValue(T value) {
+        public Builder<T> initialValue(@Nullable T value) {
             this.initialValueSupplier = value == null ? Optional.empty() : Optional.of(() -> value);
             return this;
         }

core/src/main/java/edu/wpi/grip/core/SocketHints.java

@@ -10,6 +10,8 @@
 import java.util.List;
 import java.util.function.Supplier;
 
+import static com.google.common.base.Preconditions.checkNotNull;
+
 
 /**
  * Commonly used {@link SocketHint SocketHints}
@@ -88,7 +90,7 @@ public static SocketHint<Boolean> createBooleanSocketHint(final String identifie
         }
 
         public static SocketHint<Number> createNumberSocketHint(final String identifier, Number defaultValue) {
-            return new SocketHint.Builder<>(Number.class).identifier(identifier).initialValue(defaultValue).build();
+            return createNumberSocketHintBuilder(identifier, defaultValue).build();
         }
     }
 
@@ -139,6 +141,6 @@ private static SocketHint.Builder<Number> createNumberSocketHintBuilder(final St
 
     private static SocketHint.Builder<Number> createNumberSocketHintBuilder(final String identifier,
                                                                             final Number number) {
-        return new SocketHint.Builder<>(Number.class).identifier(identifier).initialValue(number);
+        return new SocketHint.Builder<>(Number.class).identifier(identifier).initialValue(checkNotNull(number, "Number can not be null"));
     }
 }

core/src/main/java/edu/wpi/grip/core/events/ConnectionRemovedEvent.java

@@ -3,6 +3,8 @@
 import com.google.common.base.MoreObjects;
 import edu.wpi.grip.core.Connection;
 
+import static com.google.common.base.Preconditions.checkNotNull;
+
 /**
  * An event that occurs when a connection is removed from the pipeline.  This is triggered by the user deleting a
  * connection with the GUI.
@@ -14,7 +16,7 @@ public class ConnectionRemovedEvent {
      * @param connection The connection being deleted
      */
     public ConnectionRemovedEvent(Connection connection) {
-        this.connection = connection;
+        this.connection = checkNotNull(connection, "Connection cannot be null");
     }
 
     /**

core/src/main/java/edu/wpi/grip/core/events/ExceptionEvent.java

@@ -2,6 +2,7 @@
 
 import edu.wpi.grip.core.util.ExceptionWitness;
 
+import javax.annotation.Nullable;
 import java.util.Optional;
 
 import static com.google.common.base.Preconditions.checkNotNull;
@@ -22,9 +23,9 @@ public final class ExceptionEvent {
      * @param message   The message associated with this event.
      *                  If <tt>null</tt> will use {@link Exception#getMessage()}
      */
-    public ExceptionEvent(Object origin, Exception exception, String message) {
+    public ExceptionEvent(Object origin, Exception exception, @Nullable String message) {
         this.exception = Optional.of(exception);
-        this.origin = checkNotNull(origin, "The origin can not be null");
+        this.origin = checkNotNull(origin, "The origin cannot be null");
         this.message = message != null ? message : exception.getMessage();
     }
 
@@ -33,9 +34,9 @@ public ExceptionEvent(Object origin, Exception exception, String message) {
      * @param message The message associated with this event.
      */
     public ExceptionEvent(Object origin, String message) {
-        this.origin = checkNotNull(origin, "The origin can not be null");
+        this.origin = checkNotNull(origin, "The origin cannot be null");
         this.exception = Optional.empty();
-        this.message = message;
+        this.message = checkNotNull(message, "The message cannot be null");
     }
 
     /**

core/src/main/java/edu/wpi/grip/core/events/OperationAddedEvent.java

@@ -3,6 +3,8 @@
 import com.google.common.base.MoreObjects;
 import edu.wpi.grip.core.Operation;
 
+import static com.google.common.base.Preconditions.checkNotNull;
+
 /**
  * Event for when a new operation is added to the application.  This happens, for example, if a user loads a new Python
  * script, or at startup for the built-in operations.  This is NOT the event for adding a new step to the pipeline.
@@ -14,7 +16,7 @@ public class OperationAddedEvent {
      * @param operation The operation being added
      */
     public OperationAddedEvent(Operation operation) {
-        this.operation = operation;
+        this.operation = checkNotNull(operation, "Operation cannot be null");
     }
 
     /**

core/src/main/java/edu/wpi/grip/core/events/SocketConnectedChangedEvent.java

@@ -3,6 +3,8 @@
 import com.google.common.base.MoreObjects;
 import edu.wpi.grip.core.Socket;
 
+import static com.google.common.base.Preconditions.checkNotNull;
+
 /**
  * This event is sent when the state of a socket (connected vs. disconnected) is changed.  Specifically, this will only
  * be called if the number of connections either goes to zero when it was non-zero, or when it was zero and one is
@@ -17,7 +19,7 @@ public class SocketConnectedChangedEvent {
      * @param socket The socket that was either connected or disconneted.
      */
     public SocketConnectedChangedEvent(Socket socket) {
-        this.socket = socket;
+        this.socket = checkNotNull(socket, "Socket cannot be null");
     }
 
     /**