Resolves PR Review Comments, Fixes Formatting

Author: JLLeitschuh

core/src/main/java/edu/wpi/grip/core/Connection.java

@@ -45,21 +45,17 @@ public InputSocket<T> getInputSocket() {
         return this.inputSocket;
     }
 
-    private void runConnection() {
-        inputSocket.setValueOptional(outputSocket.getValue());
-    }
-
     @Subscribe
     public void onConnectionAdded(ConnectionAddedEvent event) {
         if (event.getConnection().equals(this)) {
-            runConnection();
+            inputSocket.setValueOptional(outputSocket.getValue());
         }
     }
 
     @Subscribe
     public void onOutputChanged(SocketChangedEvent e) {
         if (e.getSocket() == outputSocket) {
-            runConnection();
+            inputSocket.setValueOptional(outputSocket.getValue());
         }
     }
 

core/src/main/java/edu/wpi/grip/core/GRIPCoreModule.java

@@ -40,7 +40,8 @@ public <I> void hear(TypeLiteral<I> type, TypeEncounter<I> encounter) {
 
         bind(EventBus.class).toInstance(eventBus);
 
-        install(new FactoryModuleBuilder().build(new TypeLiteral<Connection.Factory<Object>>(){}));
+        install(new FactoryModuleBuilder().build(new TypeLiteral<Connection.Factory<Object>>() {
+        }));
 
 
         bind(Source.SourceFactory.class).to(Source.SourceFactoryImpl.class);

core/src/main/java/edu/wpi/grip/core/Main.java

@@ -23,6 +23,8 @@ public class Main {
     private Project project;
     @Inject
     private EventBus eventBus;
+    @Inject
+    private Logger logger;
 
     @SuppressWarnings("PMD.SignatureDeclareThrowsException")
     public static void main(String[] args) throws Exception {
@@ -74,15 +76,11 @@ public void start(String[] args) throws IOException, InterruptedException {
     }
 
     /**
-     * When an unexpected error happens in headless mode, print a stack trace and exit.  Obviously we cannot show
-     * a dialog here, so this will have to do until we have proper logging.
-     * <p>
-     * TODO: put actual logging in this method
+     * When an unexpected error happens in headless mode, print a stack trace and exit.
      */
     @Subscribe
     public final void onUnexpectedThrowableEvent(UnexpectedThrowableEvent event) {
-        System.out.println(event.getMessage());
-        event.getThrowable().printStackTrace();
+        logger.log(Level.SEVERE, "UnexpectedThrowableEvent", event.getThrowable());
         if (event.isFatal()) {
             System.exit(1);
         }

core/src/main/java/edu/wpi/grip/core/Pipeline.java

@@ -25,11 +25,13 @@
 @XStreamAlias(value = "grip:Pipeline")
 public class Pipeline {
 
-    @Inject @XStreamOmitField private EventBus eventBus;
+    @Inject
+    @XStreamOmitField
+    private EventBus eventBus;
 
-    private List<Source> sources = new ArrayList<>();
-    private List<Step> steps = new ArrayList<>();
-    private Set<Connection> connections = new HashSet<>();
+    private final List<Source> sources = new ArrayList<>();
+    private final List<Step> steps = new ArrayList<>();
+    private final Set<Connection> connections = new HashSet<>();
 
     /**
      * Remove everything in the pipeline
@@ -142,7 +144,7 @@ public synchronized void addStep(int index, Step step) {
         this.eventBus.post(new StepAddedEvent(step, index));
     }
 
-    public synchronized  void addStep(Step step) {
+    public synchronized void addStep(Step step) {
         addStep(this.steps.size(), step);
     }
 

core/src/main/java/edu/wpi/grip/core/Source.java

@@ -24,9 +24,9 @@ public static class SourceFactoryImpl implements SourceFactory {
 
         @Override
         public Source create(Class type, Properties properties) throws IOException {
-            if(type.isAssignableFrom(CameraSource.class)) return cameraFactory.create(properties);
-            else if(type.isAssignableFrom(ImageFileSource.class)) return imageFactory.create(properties);
-            else if(type.isAssignableFrom(MultiImageFileSource.class)) return multiImageFactory.create(properties);
+            if (type.isAssignableFrom(CameraSource.class)) return cameraFactory.create(properties);
+            else if (type.isAssignableFrom(ImageFileSource.class)) return imageFactory.create(properties);
+            else if (type.isAssignableFrom(MultiImageFileSource.class)) return multiImageFactory.create(properties);
             else throw new IllegalArgumentException(type + " was not a valid type");
         }
     }

core/src/main/java/edu/wpi/grip/core/serialization/ConnectionConverter.java

@@ -7,7 +7,10 @@
 import com.thoughtworks.xstream.converters.UnmarshallingContext;
 import com.thoughtworks.xstream.io.HierarchicalStreamReader;
 import com.thoughtworks.xstream.io.HierarchicalStreamWriter;
-import edu.wpi.grip.core.*;
+import edu.wpi.grip.core.Connection;
+import edu.wpi.grip.core.InputSocket;
+import edu.wpi.grip.core.OutputSocket;
+import edu.wpi.grip.core.Socket;
 import edu.wpi.grip.core.events.ConnectionAddedEvent;
 
 import javax.inject.Inject;
@@ -19,8 +22,10 @@
  */
 public class ConnectionConverter<T> implements Converter {
 
-    @Inject private EventBus eventBus;
-    @Inject private Connection.Factory<Object> connectionFactory;
+    @Inject
+    private EventBus eventBus;
+    @Inject
+    private Connection.Factory<Object> connectionFactory;
 
     @Override
     public void marshal(Object source, HierarchicalStreamWriter writer, MarshallingContext context) {

core/src/main/java/edu/wpi/grip/core/serialization/Project.java

@@ -18,9 +18,12 @@
 @Singleton
 public class Project {
 
-    @Inject private EventBus eventBus;
-    @Inject private Pipeline pipeline;
-    @Inject private Palette palette;
+    @Inject
+    private EventBus eventBus;
+    @Inject
+    private Pipeline pipeline;
+    @Inject
+    private Palette palette;
 
     protected final XStream xstream = new XStream();
     private Optional<File> file = Optional.empty();

core/src/main/java/edu/wpi/grip/core/serialization/SocketConverter.java

@@ -29,8 +29,10 @@ public class SocketConverter implements Converter {
     final private static String SOCKET_ATTRIBUTE = "socket";
     final private static String PREVIEWED_ATTRIBUTE = "previewed";
 
-    @Inject private Pipeline pipeline;
-    @Inject private Project project;
+    @Inject
+    private Pipeline pipeline;
+    @Inject
+    private Project project;
 
     @Override
     public void marshal(Object obj, HierarchicalStreamWriter writer, MarshallingContext context) {

core/src/main/java/edu/wpi/grip/core/serialization/SourceConverter.java

@@ -27,9 +27,12 @@
  */
 public class SourceConverter implements Converter {
 
-    @Inject private EventBus eventBus;
-    @Inject private Project project;
-    @Inject private Source.SourceFactory sourceFactory;
+    @Inject
+    private EventBus eventBus;
+    @Inject
+    private Project project;
+    @Inject
+    private Source.SourceFactory sourceFactory;
 
     @Override
     public void marshal(Object obj, HierarchicalStreamWriter writer, MarshallingContext context) {

core/src/main/java/edu/wpi/grip/core/serialization/StepConverter.java

@@ -22,10 +22,14 @@ public class StepConverter implements Converter {
 
     private final static String NAME_ATTRIBUTE = "name";
 
-    @Inject private EventBus eventBus;
-    @Inject private Palette palette;
-    @Inject private Pipeline pipeline;
-    @Inject private Step.Factory stepFactory;
+    @Inject
+    private EventBus eventBus;
+    @Inject
+    private Palette palette;
+    @Inject
+    private Pipeline pipeline;
+    @Inject
+    private Step.Factory stepFactory;
 
     @Override
     public void marshal(Object source, HierarchicalStreamWriter writer, MarshallingContext context) {