Skip to content

activate() does not fail despite an error in @venly/connect #12

Description

@sinolopes

The activate function is supposed to fail if an error is made by a child component/function call.

example on the metamask connector:

  1. launch the activate function
  2. metamask opens with the connection request
  3. the connection is refused which causes an error
  4. in the connector we therefore execute: this.actions.startActivation()

the variable isActivating is reset to false, so we can run the activate function even after refusing the connection

example on the venly connector:

  1. launch the activate function
  2. venly connector open a window with the connection request
  3. we close the new window
  4. this causes an error in @venly/connect/dist/connect/Flows.js

This does not cause an error in the connector, so we are blocked because if the variable isActivating remains true we cannot execute the activate function.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions