From 9ad7c6824ba12306668d8177f113fa5f224df5c9 Mon Sep 17 00:00:00 2001
From: StuartFerguson <stuart_ferguson1development@outlook.com>
Date: Mon, 3 Aug 2026 11:57:30 +0100
Subject: [PATCH] fix: resolve merchant worker startup DI

---
 TransactionProcessing.MerchantPos/Program.cs    |  3 +--
 TransactionProcessing.MerchantPos/WorkerHost.cs | 17 ++++++++++++-----
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/TransactionProcessing.MerchantPos/Program.cs b/TransactionProcessing.MerchantPos/Program.cs
index ebc3bc0..9b7f87c 100644
--- a/TransactionProcessing.MerchantPos/Program.cs
+++ b/TransactionProcessing.MerchantPos/Program.cs
@@ -59,10 +59,9 @@
 
     builder.Services.RegisterHttpClient<ISecurityServiceClient, SecurityServiceClient>();
     builder.Services.RegisterHttpClient<ITransactionProcessorClient, TransactionProcessorClient>();
-    builder.Services.AddHttpClient();
     builder.Services.AddScoped<IEfRepository, EfRepository>();
-    builder.Services.AddScoped<IApiClient, ApiClient>();
     builder.Services.AddScoped<MerchantRuntime>();
+    builder.Services.AddHttpClient<IApiClient, ApiClient>();
     builder.Services.AddSingleton<IMerchantRuntimeFactory, MerchantRuntimeFactory>();
 
     builder.Services.AddDbContext<MerchantDbContext>((sp, options) =>
diff --git a/TransactionProcessing.MerchantPos/WorkerHost.cs b/TransactionProcessing.MerchantPos/WorkerHost.cs
index 595ec1c..61c9cbb 100644
--- a/TransactionProcessing.MerchantPos/WorkerHost.cs
+++ b/TransactionProcessing.MerchantPos/WorkerHost.cs
@@ -59,11 +59,18 @@ private void SyncMerchantWorkers(CancellationToken hostToken)
                 continue;
             }
 
-            StartMerchantWorker(
-                (settings.ServiceClientId, settings.ServiceClientSecret),
-                (settings.ClientId, settings.ClientSecret),
-                merchant,
-                hostToken);
+            try
+            {
+                StartMerchantWorker(
+                    (settings.ServiceClientId, settings.ServiceClientSecret),
+                    (settings.ClientId, settings.ClientSecret),
+                    merchant,
+                    hostToken);
+            }
+            catch (Exception ex)
+            {
+                Logger.LogError($"Failed to start merchant worker for {merchant.MerchantName} ({merchant.MerchantId})", ex);
+            }
         }
     }