Skip to content

[Hackathon] dry-run run sample should include a failed run-scoped step #197

Description

@JerryNee

Discord Username / User ID

JerryNee / jerry_nee

What does this improvement do?

Follow-up to PR #136 requested by maintainer zeshi-du: the main run-scoped step rendering gap was closed by #167, but the dry-run sample still only demonstrates successful run-scoped steps. test steps --run-id ... --dry-run should include a failed assertion step with non-null error text and a matching run-level failedStepIndex so offline users and agents can see the failure/error mapping without credentials or network.

Details / implementation notes

Maintainer context: #136 (comment)

Current behavior on main: src/lib/dry-run/samples.ts has the getRun sample as a passed run with failedStepIndex: null and only passed steps. That means the dry-run path does not exercise the run-scoped failed-step shape (stepType, error, and outcomeContributesToFailure).

Proposed fix:

  • enrich the getRun dry-run sample with a failed assertion step that carries non-null error text
  • set the surrounding run fields consistently, including status, failedStepIndex, failureKind, and stepSummary
  • add focused tests in src/lib/dry-run/samples.test.ts so the dry-run sample keeps a failed run-scoped step and links it via failedStepIndex

Scope is intentionally limited to the dry-run sample/test slice the maintainer called out; no renderer refactor or broader steps behavior change.

Confirmations

  • I have searched existing issues and this is not a duplicate.
  • I have provided my Discord identity above for reward coordination.

Metadata

Metadata

Assignees

Labels

hackathonCLI hackathon submissionsin-progressAssigned and actively being worked on

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions