Discord Username / User ID
JerryNee / jerry_nee
What does this improvement do?
Follow-up to PR #136 requested by maintainer zeshi-du: the main run-scoped step rendering gap was closed by #167, but the dry-run sample still only demonstrates successful run-scoped steps. test steps --run-id ... --dry-run should include a failed assertion step with non-null error text and a matching run-level failedStepIndex so offline users and agents can see the failure/error mapping without credentials or network.
Details / implementation notes
Maintainer context: #136 (comment)
Current behavior on main: src/lib/dry-run/samples.ts has the getRun sample as a passed run with failedStepIndex: null and only passed steps. That means the dry-run path does not exercise the run-scoped failed-step shape (stepType, error, and outcomeContributesToFailure).
Proposed fix:
- enrich the
getRun dry-run sample with a failed assertion step that carries non-null error text
- set the surrounding run fields consistently, including
status, failedStepIndex, failureKind, and stepSummary
- add focused tests in
src/lib/dry-run/samples.test.ts so the dry-run sample keeps a failed run-scoped step and links it via failedStepIndex
Scope is intentionally limited to the dry-run sample/test slice the maintainer called out; no renderer refactor or broader steps behavior change.
Confirmations
Discord Username / User ID
JerryNee / jerry_nee
What does this improvement do?
Follow-up to PR #136 requested by maintainer
zeshi-du: the main run-scoped step rendering gap was closed by #167, but the dry-run sample still only demonstrates successful run-scoped steps.test steps --run-id ... --dry-runshould include a failed assertion step with non-null error text and a matching run-level failedStepIndex so offline users and agents can see the failure/error mapping without credentials or network.Details / implementation notes
Maintainer context: #136 (comment)
Current behavior on main:
src/lib/dry-run/samples.tshas thegetRunsample as a passed run withfailedStepIndex: nulland only passed steps. That means the dry-run path does not exercise the run-scoped failed-step shape (stepType,error, andoutcomeContributesToFailure).Proposed fix:
getRundry-run sample with a failed assertion step that carries non-nullerrortextstatus,failedStepIndex,failureKind, andstepSummarysrc/lib/dry-run/samples.test.tsso the dry-run sample keeps a failed run-scoped step and links it viafailedStepIndexScope is intentionally limited to the dry-run sample/test slice the maintainer called out; no renderer refactor or broader steps behavior change.
Confirmations