Code improvements

Author: TobiGr

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java

@@ -43,15 +43,15 @@ public static JsonObject getJsonData(final String html, final String variable)
 
     /**
      * Translate all these parameters together to the URL of the corresponding album or track
-     * using the mobile api
+     * using the mobile API
      */
     public static String getStreamUrlFromIds(final long bandId, final long itemId, final String itemType)
             throws ParsingException {
 
         try {
             final String jsonString = NewPipe.getDownloader().get(
                     "https://bandcamp.com/api/mobile/22/tralbum_details?band_id=" + bandId
-                            + "&tralbum_id=" + itemId + "&tralbum_type=" + itemType.substring(0, 1))
+                            + "&tralbum_id=" + itemId + "&tralbum_type=" + itemType.charAt(0))
                     .responseBody();
 
             return JsonParser.object().from(jsonString).getString("bandcamp_url").replace("http://", "https://");
@@ -88,7 +88,7 @@ public static String smartConcatenate(final String[] strings, final String comma
 
         }
 
-        return String.valueOf(result);
+        return result.toString();
     }
 
     /**

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampRadioInfoItemExtractor.java

@@ -14,7 +14,7 @@
 
 public class BandcampRadioInfoItemExtractor implements StreamInfoItemExtractor {
 
-    private JsonObject show;
+    private final JsonObject show;
 
     public BandcampRadioInfoItemExtractor(final JsonObject radioShow) {
         show = radioShow;

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampSuggestionExtractor.java

@@ -37,7 +37,7 @@ public List<String> suggestionList(final String query) throws IOException, Extra
             final JsonArray jsonArray = fuzzyResults.getObject("auto")
                     .getArray("results");
 
-            final ArrayList<String> suggestions = new ArrayList<>();
+            final List<String> suggestions = new ArrayList<>();
 
             for (final Object fuzzyResult : jsonArray) {
                 final String res = ((JsonObject) fuzzyResult).getString("name");
@@ -52,6 +52,5 @@ public List<String> suggestionList(final String query) throws IOException, Extra
             return Collections.emptyList();
         }
 
-
     }
 }

extractor/src/test/java/org/schabi/newpipe/extractor/services/bandcamp/BandcampStreamLinkHandlerFactoryTest.java

@@ -48,5 +48,6 @@ public void testAcceptUrl() throws ParsingException {
         assertTrue(linkHandler.acceptUrl("http://ZachBenson.Bandcamp.COM/Track/U-I-Tonite/"));
         assertTrue(linkHandler.acceptUrl("https://interovgm.com/track/title"));
         assertTrue(linkHandler.acceptUrl("http://bandcamP.com/?show=38"));
+        assertTrue(linkHandler.acceptUrl("https://goodgoodblood-tl.bandcamp.com/track/when-it-all-wakes-up"));
     }
 }