Skip to content

Commit f2e7c7e

Browse files
committed
Replace Vector with ArrayList for performance improvements
I could not figure out, why these two methods are necessary.
1 parent 48fd8ca commit f2e7c7e

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItemsCollector.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.schabi.newpipe.extractor.InfoItemsCollector;
55
import org.schabi.newpipe.extractor.exceptions.ParsingException;
66

7+
import java.util.ArrayList;
78
import java.util.List;
89
import java.util.Vector;
910

@@ -95,7 +96,7 @@ public void commit(CommentsInfoItemExtractor extractor) {
9596
}
9697

9798
public List<CommentsInfoItem> getCommentsInfoItemList() {
98-
List<CommentsInfoItem> siiList = new Vector<>();
99+
List<CommentsInfoItem> siiList = new ArrayList<>();
99100
for (InfoItem ii : super.getItems()) {
100101
if (ii instanceof CommentsInfoItem) {
101102
siiList.add((CommentsInfoItem) ii);

extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItemsCollector.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.schabi.newpipe.extractor.exceptions.FoundAdException;
66
import org.schabi.newpipe.extractor.exceptions.ParsingException;
77

8+
import java.util.ArrayList;
89
import java.util.Comparator;
910
import java.util.List;
1011
import java.util.Vector;
@@ -111,7 +112,7 @@ public void commit(StreamInfoItemExtractor extractor) {
111112
}
112113

113114
public List<StreamInfoItem> getStreamInfoItemList() {
114-
List<StreamInfoItem> siiList = new Vector<>();
115+
List<StreamInfoItem> siiList = new ArrayList<>();
115116
for (InfoItem ii : super.getItems()) {
116117
if (ii instanceof StreamInfoItem) {
117118
siiList.add((StreamInfoItem) ii);

0 commit comments

Comments
 (0)